Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_logState not implemented #194

Closed
danielghost opened this issue Jun 12, 2023 · 2 comments · Fixed by #225
Closed

_logState not implemented #194

danielghost opened this issue Jun 12, 2023 · 2 comments · Fixed by #225
Assignees
@danielghost
Labels
bug released

Comments

@danielghost
Copy link
Contributor

426c583 added a feature to control whether the state is included in the log. The schemas and example.json include the attribute, but it doesn't look like it is actually used in the code.

I assume https://github.com/adaptlearning/adapt-contrib-trickle/blob/master/js/models.js#L325 should account for this attribute?
@oliverfoster
Copy link
Member

Yeas, exactly.

danielghost added a commit that referenced this issue May 24, 2024
@danielghost
Update: implement missing _logState condition (fixes #194).
8c53aa9
@danielghost danielghost mentioned this issue May 24, 2024
Merged
@danielghost danielghost self-assigned this May 24, 2024
joe-allen-89 pushed a commit that referenced this issue May 29, 2024
@danielghost
Update: implement missing _logState condition (fixes #194). (#225)
6690191
github-actions bot pushed a commit that referenced this issue May 29, 2024
@semantic-release-bot
Chore(release): 7.4.0 [skip ci]
c7c1816 
# [7.4.0](v7.3.2...v7.4.0) (2024-05-29)

### Update

* implement missing `_logState` condition (fixes #194). (#225) ([6690191](6690191)), closes [#194](#194) [#225](#225)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 7.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielghost danielghost

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: implement missing _logState condition adaptlearning/adapt-contrib-trickle
2 participants
@danielghost @oliverfoster