Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile body and instruction behave differently #538

Closed
swashbuck opened this issue May 13, 2024 · 1 comment · Fixed by #539
Closed

Mobile body and instruction behave differently #538

swashbuck opened this issue May 13, 2024 · 1 comment · Fixed by #539
Assignees
@swashbuck
Labels
enhancement New feature or request

Comments

@swashbuck
Copy link
Contributor

swashbuck commented May 13, 2024 •
edited

Subject of the issue

When _isNarrativeOnMobile is true, both mobileBody and mobileInstruction are correctly shown on mobile. However, when _isNarrativeOnMobile is false, only mobileInstruction is shown on mobile and the body text uses body (not mobileBody).

mobileBody should always be shown on mobile view regardless of the value of _isNarrativeOnMobile.

We should also check whether the issue is present or caused by the Narrative plugin.
@swashbuck swashbuck added the bug Something isn't working label May 13, 2024
@swashbuck
Copy link
Contributor Author

I believe this is actually an issue with adapt-contrib-core. In the header.jsx template, we only check for the existence of mobileInstruction instead of both that and mobileBody.

@swashbuck swashbuck transferred this issue from adaptlearning/adapt-contrib-hotgraphic May 15, 2024
@swashbuck swashbuck self-assigned this May 15, 2024
@swashbuck swashbuck added enhancement New feature or request and removed bug Something isn't working labels May 15, 2024
@swashbuck swashbuck mentioned this issue May 15, 2024
Merged
swashbuck added a commit that referenced this issue May 29, 2024
@swashbuck
New: Allow any component to use mobileBody for smaller devices (fixes #…
c8e4c95 
…538)
github-actions bot pushed a commit that referenced this issue May 29, 2024
@semantic-release-bot
Chore(release): 6.48.0
4b8a99a 
# [6.48.0](v6.47.0...v6.48.0) (2024-05-29)

### New

* Allow any component to use mobileBody for smaller devices (fixes #538) ([c8e4c95](c8e4c95)), closes [#538](#538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
enhancement New feature or request
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
1 participant
@swashbuck