Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve schema help text for Animation classes #389

Open
swashbuck opened this issue Jun 5, 2023 · 2 comments
Open

Improve schema help text for Animation classes #389

swashbuck opened this issue Jun 5, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Jun 5, 2023

Subject of the issue

The AAT allows you to add an animation to a block, component or article. However, the tooltip help for "Classes" does not give any indication of what classes to use.

Suggestion

It would be more user-friendly to list out the default Vanilla animation classes with the caveat that there may be additional custom classes provided by the theme. The new help text could be:

The CSS class(es) to add to the element. These include 'fade-in-top', 'fade-in-bottom', 'fade-in-left', and 'fade-in-right' as well as any custom classes supplied by the theme.

Alternatively, we could offer these 4 class options in a dropdown, but that would remove the ability to use any custom theme classes. This would be simpler for the course creator, though.

animation-classes
@swashbuck swashbuck added the enhancement New feature or request label Jun 5, 2023
@kirsty-hames
Copy link
Contributor

Alternatively, we could offer these 4 class options in a dropdown, but that would remove the ability to use any custom theme classes. This would be simpler for the course creator, though.

Hey @swashbuck, how about both? A dropdown for existing Vanilla classes and a _classes property to support custom styles.

In general for AAT, I'd like to see existing Vanilla classes in a dropdown so it's easier for course authors to see styles available and a _classes property for customisation.

@swashbuck
Copy link
Contributor Author

@kirsty-hames Yep, sounds good to me. The best of both worlds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants