Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 186 dynamic commands #207

Merged
merged 7 commits into from Jul 13, 2021
Merged

Feature/issue 186 dynamic commands #207

merged 7 commits into from Jul 13, 2021

Conversation

adambajguz
Copy link
Owner

No description provided.

@adambajguz adambajguz linked an issue Jul 12, 2021 that may be closed by this pull request
How to dynamically create and remove commands? And other features requests #186
Open
@codecov
Copy link

codecov bot commented Jul 12, 2021 •
edited

Codecov Report

Merging #207 (cb200bc) into develop (d6f7e2f) will decrease coverage by 6.31%.
The diff coverage is 71.19%.

❗ Current head cb200bc differs from pull request most recent head f928335. Consider uploading reports for the commit f928335 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #207      +/-   ##
===========================================
- Coverage    88.76%   82.45%   -6.31%     
===========================================
  Files          103      216     +113     
  Lines         3026     4245    +1219     
  Branches       476      571      +95     
===========================================
+ Hits          2686     3500     +814     
- Misses         241      604     +363     
- Partials        99      141      +42
Impacted Files Coverage Δ
...rc/Typin/Typin.Core/Attributes/CommandAttribute.cs 100.00% <ø> (ø)
src/Typin/Typin.Core/Schemas/DirectiveSchema.cs 83.33% <0.00%> (-2.78%) ⬇️
src/Typin/Typin.Tests.Data.Common/Console/Ansi.cs 42.59% <ø> (ø)
...in.Tests.Data.Common/Console/VirtualAnsiConsole.cs 74.63% <ø> (ø)
...omTypes/Initializable/CustomStringConstructible.cs 100.00% <ø> (ø)
.../CustomTypes/Initializable/CustomStringParsable.cs 100.00% <ø> (ø)
...alizable/CustomStringParsableWithFormatProvider.cs 100.00% <ø> (ø)
...leByConverter/InitializableClassTypeByConverter.cs 100.00% <ø> (ø)
...ter/InitializableClassTypeByConverter_Converter.cs 66.67% <ø> (ø)
...tializableClassTypeByConverter_FailingConverter.cs 50.00% <ø> (ø)
... and 259 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1bc800...f928335. Read the comment docs.

@adambajguz adambajguz force-pushed the feature/issue-186_dynamic-commands branch from 4e38395 to f928335 Compare July 12, 2021 18:13
@adambajguz adambajguz changed the base branch from master to develop July 12, 2021 18:13
@adambajguz adambajguz force-pushed the feature/issue-186_dynamic-commands branch 3 times, most recently from cb200bc to f928335 Compare July 13, 2021 15:54
@adambajguz adambajguz marked this pull request as ready for review July 13, 2021 15:54
@adambajguz adambajguz merged commit 6d159d9 into develop Jul 13, 2021
@adambajguz adambajguz deleted the feature/issue-186_dynamic-commands branch July 13, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to dynamically create and remove commands? And other features requests
1 participant
@adambajguz