Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block keyboard input during execution of boot.py on non-usb boards #9179

Open
bill88t opened this issue Apr 14, 2024 · 2 comments
Open

Block keyboard input during execution of boot.py on non-usb boards #9179

bill88t opened this issue Apr 14, 2024 · 2 comments

Comments

@bill88t
Copy link

bill88t commented Apr 14, 2024

On usb boards it's not possible to interfere with boot.py since usb doesn't start up that early.
However on non-usb boards it's very much possible to do so.

This however makes it possible for serial noise (from plugging the board in) to send a KeyboardInterrupt and stop it.

I think it would eventually be a good idea to outright block all input while boot.py is running.

@bill88t
Copy link
Author

bill88t commented Apr 14, 2024

This should also perhaps extend to safemode.py.

It's pretty much the boot.py of safe mode.
Having it be interrupted by a random serial interrupt, leaving the app stopped on a crashed headless board doesn't sound all that fun.

@dhalbert dhalbert added this to the 9.x.x milestone Apr 18, 2024
@tannewt
Copy link
Member

tannewt commented Apr 22, 2024

My intention is that workflows start after boot.py is run but I think you are right that UART starts earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants