Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploading a file that is too large via Web Workflow causes Hard Fault #8109

Closed
makermelissa opened this issue Jun 22, 2023 · 1 comment · Fixed by #8667
Closed

Uploading a file that is too large via Web Workflow causes Hard Fault #8109

makermelissa opened this issue Jun 22, 2023 · 1 comment · Fixed by #8667
Assignees
@tannewt
Labels
bug web workflow
Milestone
Long term

Comments

@makermelissa
Copy link
Collaborator

CircuitPython version

8.2.0-beta.1-12-g0da62416a-dirty

Code/REPL

N/A

Behavior

per @ladyada:

i don't think anyone tried uploading a file that is 'too large' - the board hardfaults

Description

No response

Additional information

No response
@dhalbert
Copy link
Collaborator

8.2.0-beta.1-12-g0da62416a-dirty is the same as #8100, so tip of main at the moment.

@tannewt tannewt added this to the Long term milestone Jun 23, 2023
@tannewt tannewt self-assigned this Nov 28, 2023
@tannewt tannewt mentioned this issue Nov 28, 2023
Merged
dhalbert pushed a commit that referenced this issue Nov 29, 2023
@tannewt
Improve web workflow error handling
8208ca3 
* Disable Nagle at the end of error messages so they are sent before
  the socket is closed.
* Correctly discard file contents when the PUT file is too large.
* Correctly reset file size after failure to setting it too large.
* Change diskinfo.json to be list of disks in preparation of supporting
  multiple disks.
* Bump version to 3 for the above change.
* Document diskinfo.json.

Fixes #8109
lovrojakic pushed a commit to lovrojakic/circuitpython that referenced this issue Jan 9, 2024
@tannewt @lovrojakic
Improve web workflow error handling
71c8993 
* Disable Nagle at the end of error messages so they are sent before
  the socket is closed.
* Correctly discard file contents when the PUT file is too large.
* Correctly reset file size after failure to setting it too large.
* Change diskinfo.json to be list of disks in preparation of supporting
  multiple disks.
* Bump version to 3 for the above change.
* Document diskinfo.json.

Fixes adafruit#8109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tannewt tannewt

Labels
bug web workflow
Projects
None yet
Milestone
Long term
Development

Successfully merging a pull request may close this issue.

Improve web workflow error handling tannewt/circuitpython
3 participants
@tannewt @makermelissa @dhalbert