Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API V2: Remove Initial Pin Configuration Routine #551

Open
brentru opened this issue Mar 1, 2024 · 0 comments
Open

API V2: Remove Initial Pin Configuration Routine #551

brentru opened this issue Mar 1, 2024 · 0 comments
Labels

Comments

@brentru
Copy link
Member

brentru commented Mar 1, 2024

Within the connect() loop, there is a blocking loop that polls until the pinCfgCompleted flag is set. While Loren and I were auditing code in preparation for the transition to api-v2, we noticed that the pinCfgCompleted flag is only set when a pin configuration message arrives at the device.

Expected Behavior: If the device does not receive a pin configuration message from the broker, this segment of code will poll forever causing an endless reboot due to the watchdog resetting.

Current Behavior: The broker incorrectly sends a (empty?) pin configuration message that sets the pinCfgCompleted flag regardless if any components exist on the device page.

Migration for API V2: In the Protobuf for API V2, we removed the message containing this is_complete field. In Arduino, the code surrounding handling this message and enforcing this check should be removed.

@brentru brentru added the api-v2 label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant