Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failures due to board.py exceeding maximum lines permitted by Pylint #296

Open
NathanY3G opened this issue May 21, 2023 · 2 comments

Comments

@NathanY3G
Copy link
Contributor

NathanY3G commented May 21, 2023

At the time of writing the board.py source file contains 990 lines. The maximum permitted by the project's Pylint configuration is 1000. Attempting to add support for a new board resulted in build failures.

One possible solution might be to refactor some of the if-elif constructs to use a dictionary instead.

@makermelissa
Copy link
Contributor

Yeah, good idea. Another solution that could help would be to move a lot of the private id functions to another module and just import from there. That way it shouldn't break anything.

@NathanY3G
Copy link
Contributor Author

That's a great idea @makermelissa. To check that I have understood your idea correctly I have created a draft PR #299. I have initially chosen a single but very common board to aid testing. I would be grateful if you could take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants