Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isEmpty() dereferences pointer before checking if it is NULL. #153

Open
jpuderer opened this issue Jan 28, 2024 · 0 comments
Open

isEmpty() dereferences pointer before checking if it is NULL. #153

jpuderer opened this issue Jan 28, 2024 · 0 comments

Comments

@jpuderer
Copy link

if (',' != *pStart && '*' != *pStart && pStart != NULL)

I'm getting a crash in this library. I don't know if this is the root cause, but the logic in isEmpty is backwards.

The NULL check needs to happen before dereferencing the pointer.

Should be...
if (pStart != NULL && ',' != *pStart && '*' != *pStart)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant