Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a toggle to enable temperature compensation #36

Open
purepani opened this issue Mar 18, 2024 · 1 comment · May be fixed by #39
Open

Adding a toggle to enable temperature compensation #36

purepani opened this issue Mar 18, 2024 · 1 comment · May be fixed by #39
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@purepani
Copy link

purepani commented Mar 18, 2024 •
edited

Currently there is no way to enable the temperature compensation feature of this sensor with this library. It's possible to write to the register directly, but the position of 0mT of the output changes from 0x0 to 0x8000, so it would be helpful for the library to figure out the logic for that instead of doing it manually.
@tekktrik tekktrik added enhancement New feature or request good first issue Good for newcomers labels Mar 28, 2024
@purepani
Copy link
Author

purepani commented Apr 7, 2024 •
edited

@tekktrik I'm currently implementing this, and I was just wondering how you think it the invalid resolutions for the temperature compensation should be handled.
See https://www.melexis.com/en/documents/documentation/application-notes/application-note-mlx90393-temperature-compensation for details, but basically the temperature compensation is only functional on 16 and 17 bit resolutions, but not higher.

I'm not actually sure what the chip is doing when you have a higher resolution set, but I think the temperature compensation is just not affecting the output. It might be confusing if there's nothing that happens when a user sets the temperature compensation too high though and nothing happens, so I thought I'd go ahead and ask.

@purepani purepani linked a pull request Apr 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds temperature compensation purepani/Adafruit_CircuitPython_MLX90393
2 participants
@purepani @tekktrik