Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding latest release assumes latest tag is on master #175

Open
dhalbert opened this issue Jul 10, 2019 · 1 comment
Open

Finding latest release assumes latest tag is on master #175

dhalbert opened this issue Jul 10, 2019 · 1 comment

Comments

@dhalbert
Copy link
Contributor

I believe the current way of finding the latest tag in update-submodules.sh will find the latest tag on any branch, not just on master. For libraries, we never tag other than on master, but some day, we might. (We tag on branches in https://github.com/adafruit/circuitpython, for instance.)

For many suggestions about finding the latest tag on a branch, see https://stackoverflow.com/questions/1404796/how-to-get-the-latest-tag-name-in-current-branch-in-git

@lesamouraipourpre
Copy link
Contributor

Would changing
git submodule foreach "tag=\$(git rev-list --exclude='*-*' --tags --max-count=1); git checkout -q \$tag"
to
git submodule foreach "tag=\$(git rev-list --exclude='*-*' --tags --branches='main|master' --max-count=1); git checkout -q \$tag"
help with this?

It should theoretically restrict the tag search to main or master. I can't think of definitive way to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants