Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send_batch_data requires class instances when it should just require accept a list or dict #94

Open
evaherrada opened this issue Aug 24, 2022 · 3 comments
Assignees

Comments

@evaherrada
Copy link
Collaborator

https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO/blob/main/adafruit_io/adafruit_io.py#L607

The _asdict method needs to be run on an instance of a class to get the class attributes. It would be easier for most users to just send a list or dict.

@evaherrada
Copy link
Collaborator Author

cc @brentru

@evaherrada evaherrada self-assigned this Aug 24, 2022
@brentru
Copy link
Member

brentru commented Sep 2, 2022

@evaherrada Do you want to work on this issue next week? Tag me when there's a PR ready for review

@rbrian
Copy link

rbrian commented Sep 3, 2022

I’m available to help however I can, at the very least for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants