[Bug]: Hide reconciled transactions - wrong balance shown

[ngocphamm]

Verified issue does not already exist?

• I have searched and found no existing issue
• I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

Balance on the account is shown differently when reconciled transactions are hidden.

Not hidden

Hidden

I think another person experienced this too #2503 (comment)

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Mac OSX

[ToniCipriani]

Issue confirmed on Windows and Android PWA as well.

[MatissJanis]

👋 Would you mind providing a demo budget export so folks can reproduce the issue?
Thanks

[ngocphamm]

@MatissJanis Please use this one.

2024-05-06-My-Finances-2befb2e.zip

[joel-jeremy]

The issue occurs because the running balance calculation runs the calculations based on the queried transactions. In the case of hiding the reconciled transaction, the reconciled transaction are being excluded from the query hence the calculation is returning the wrong results.

I can think of two possible ways to fix this:

1. Revert the query to fetch all transactions (including reconciled) but do not render the reconciled transactions.
2. When toggling the reconciled transactions, recalculate the starting balance in which the running balance calculation will start from.

[youngcw]

The issue occurs because the running balance calculation runs the calculations based on the queried transactions. In the case of hiding the reconciled transaction, the reconciled transaction are being excluded from the query hence the calculation is returning the wrong results.

I can think of two possible ways to fix this:

1. Revert the query to fetch all transactions (including reconciled) but do not render the reconciled transactions.
2. When toggling the reconciled transactions, recalculate the starting balance in which the running balance calculation will start from.

I think either of those would work. The one small thing with option 1 is that the transactions may not be contiguous and that would make the running balance not align perfectly with the shown transactions. Option 2 would get around this, but could be annoying to users who would like both.