Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort filters before creating dropdown #2719

Merged
merged 4 commits into from May 13, 2024
Merged

Sort filters before creating dropdown #2719

merged 4 commits into from May 13, 2024

Conversation

dangrous
Copy link
Contributor

@dangrous dangrous commented May 6, 2024

Fixes #2626

Though we should discuss if this is how we want to move forward

@netlify Netlify
Copy link

netlify bot commented May 6, 2024 •
edited

✅ Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit b76aec3
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/663beb411a3a770008af9204
😎 Deploy Preview https://deploy-preview-2719.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label May 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.71 MB → 4.71 MB (+7 B) +0.00%
Changeset
File Δ Size
src/components/filters/FiltersMenu.jsx 📈 +7 B (+0.06%) 12.4 kB → 12.41 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/AppliedFilters.js 21.16 kB → 21.17 kB (+7 B) +0.03%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 59.81 kB 0%
static/js/wide.js 262.38 kB 0%
static/js/ReportRouter.js 1.23 MB 0%
static/js/index.js 3 MB 0%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@youngcw
Copy link
Contributor

youngcw commented May 8, 2024

Im fine with this. I think either order works fine, but this at least has a obvious order even when not looking at the ledger.

@dangrous dangrous marked this pull request as ready for review May 8, 2024 21:11
youngcw
youngcw approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@youngcw youngcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill put this as approved for now and see if anyone has any complaints

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 9, 2024
@youngcw youngcw merged commit 7e04226 into actualbudget:master May 13, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngcw youngcw youngcw approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Filters list isn't in order
2 participants
@dangrous @youngcw