Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Filters list isn't in order #2626

Closed
2 tasks done
Teprifer opened this issue Apr 18, 2024 · 6 comments · Fixed by #2719
Closed
2 tasks done

[Bug]: Filters list isn't in order #2626

Teprifer opened this issue Apr 18, 2024 · 6 comments · Fixed by #2719
Labels
bug Something isn't working good first issue Good for newcomers user interface Related to the user interface

Comments

@Teprifer
Copy link

Verified issue does not already exist?

  • I have searched and found no existing issue
  • I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

The filters list isn't alphabetical, making it come across incoherent as items aren't where you'd expect to find them in the list:

image
D, A, P, N, C, A, C, R, S

Alphabetical would be:

Account
Amount
Category
Cleared
Date
Notes
Payee
Reconciled
Saved

(Similar to #1284 but for the filter types themselves)

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Firefox

Operating System

Windows 11

@Teprifer Teprifer added the bug Something isn't working label Apr 18, 2024
@Teprifer
Copy link
Author

Occurred to me these line up to the order of columns in accounts, which provides some reasoning, but the same filter list is used in graphs where that logic doesn't apply so alphabetical seems suitable, and still does on the accounts screen.

@Teprifer Teprifer reopened this Apr 18, 2024
@MatissJanis MatissJanis added good first issue Good for newcomers help wanted Extra attention is needed user interface Related to the user interface labels Apr 19, 2024
@dangrous
Copy link
Contributor

I made a draft PR on my fork - dangrous#1 - but I'm not confident we need to fix this... I can see it both ways. Is there a way to bring it up for discussion?

@Teprifer
Copy link
Author

Could see if anyone chimes in over the next few days. I doubt anyone will have strong feelings on it either way.

It would be good to have them in an order that makes sense in all contexts rather than the one.

@youngcw
Copy link
Contributor

youngcw commented May 2, 2024

@dangrous If you want to open a PR with your change, that could be a good place to discuss

@dangrous
Copy link
Contributor

dangrous commented May 6, 2024

Yeah fair - I'll get that up today!

@dangrous
Copy link
Contributor

dangrous commented May 6, 2024

Linked above!

@github-actions github-actions bot removed the help wanted Extra attention is needed label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers user interface Related to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants