Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback]: Custom Reports #1918

Open
29 of 39 tasks
carkom opened this issue Nov 16, 2023 · 160 comments
Open
29 of 39 tasks

[Feedback]: Custom Reports #1918

carkom opened this issue Nov 16, 2023 · 160 comments
Labels
experimental feature Related to an experimental feature feedback Single feedback thread for bug reports on a new feature

Comments

@carkom
Copy link
Contributor

carkom commented Nov 16, 2023

Thanks to everyone for their input in getting this merged. Thanks to the maintainers for the reviews. Anything not listed please feel free to add to the conversation. Cheers!

Update: moving completed items down and consolidating most recent feedback items

Known Issues:

  • Newly hidden categories do not update the dashboad cards. The actual report correctly excludes newly hidden categories.
  • Table Totals need a callback

Upcoming Additions:

  • Add interval selection (by: day, week, month, year)
  • Implement disabledList so all disabled functions can get updated/maintained in one place
  • Drag and drop dashboard

UI suggestions:

  • Condsider adding Rolling Averages (like Category Spending graph)
  • Add Net Worth numbers
  • Click graph items (table cell, donut section, single bar, etc.) and see transaction that contribute to that cell *all done except table graph
  • onHover first columns (make faster)
  • Change Category sort order
  • Refactor show hidden and show empty toggles

***** Version 1 *****
Known Issues:

  • Need to find a way to freeze first row column when scrolling (table graph) (fixed by Custom report updates #1996)
  • Would like to freeze bottom "totals" row as well. Not sure it's possible (table graph) (same as above)
  • Table Rendering is funky when using filters (makes me think my rendering could be done much better) (same as above)
    • Add tnum to table formats
  • Load Payees is intermitent (must navigate to payee page to load them into app before it will work)
  • Hidden Groups crash Bar Graph
    • Hidden Groups crash Table Graph
  • Error when changing "split" drop down in "time" mode for StackedBarGraph
  • The Range: "all time" is not working.
  • Loading time for large budgets is quite slow (fixed by Custom Reports optimization #1988)
  • dataset does not update on "Type" change
  • Add interval selection (by: day, week, fortnight, month, year)

Upcoming Additions:

  • Saving the graph to the "Reports" homepage ([WIP] Save custom reports #1924)
    • Drag and drop to reorder
    • "..." to rename or delete on homepage
  • Make relative saved graphs update when opened (eg. current month)
  • Enable "Show Label" button
  • Enable "Show Legend" button
  • Add range options "year to date" and "last year"
  • Figure out logic for when/how to show labels on each graph
  • Create Live/Static choice for date ranges.

UI suggestions from reviewers (open to discussion, leave your comment!):

  • Legend and Summary on by default (changed to global variables)
  • Condsider adding Rolling Averages (like Category Spending graph)
  • Display percentages in pie chart (argument here is that it could get really busy with 30+ categories)
    • It's been suggested to only display pieces with more than 10%
  • Collapse Groups in matrix table (not entirely neccessary since groups can be found in the "split" menu). A nice functionality to consider though.
  • Remove hover highlight on Bar/StackedBar
  • Add Net Worth numbers
  • Add select all and unselect all buttons to categorySelector
  • Use global variables for view (legend/summart/labels)

Backend planned additions/changes to improve code/functionality:

  • Improve state variables
  • Implement disabledList so all disabled functions can get updated/maintained in one place
@carkom carkom added the bug Something isn't working label Nov 16, 2023
@Kidglove57
Copy link

Great work! It looks as if it must have been a huge task for which we are very grateful indeed.

My main use will be of the Table view. As you say, the alignment of numbers (particularly larger numbers) in the table still needs some work and also this alignment seems inconsistent between various time-scale views.

The "year to date" and "last year" options will be great additions!

@Kidglove57
Copy link

In my dream world I would also love to be able to click through the table entry to see the underlying transactions!

@youngcw
Copy link
Contributor

youngcw commented Nov 17, 2023

Hidden category groups break the processing. The error below is what gets printed, but the core of the issue is that the categoryGroupCalcData ends up with a null entry for each hidden category.

default-spreadsheet.tsx:350 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'id')
  ¦ at default-spreadsheet.tsx:350:19
  ¦ at Array.map (<anonymous>)
  ¦ at default-spreadsheet.tsx:349:29
  ¦ at Array.map (<anonymous>)
  ¦ at default-spreadsheet.tsx:332:40
(anonymous) @ default-spreadsheet.tsx:350
(anonymous) @ default-spreadsheet.tsx:349
(anonymous) @ default-spreadsheet.tsx:332
Promise.then (async)
(anonymous) @ useReport.js:11
sS @ react-dom.production.min.js:244
lM @ react-dom.production.min.js:286
lP @ react-dom.production.min.js:283
lO @ react-dom.production.min.js:281
ly @ react-dom.production.min.js:273
i_ @ react-dom.production.min.js:127
(anonymous) @ react-dom.production.min.js:267

@Shazib
Copy link
Contributor

Shazib commented Nov 18, 2023

Awesome work. Couple issues i've noticed.

  • Selecting a payee filter seems to show it as deleted

image

  • Flipping between the 'Type' when in 'Time' mode crashes the app.

@Kidglove57
Copy link

Kidglove57 commented Nov 18, 2023

Flipping between the 'Type' when in 'Time' mode crashes the app
I have been unable to reproduce this crash on my live budget. Although I do get the crash when selecting a Split other than category
EDIT I should have added that this happened in the stacked bar graph. But seems to be fixed in 1930.

@Redbox3070
Copy link

Really happy to have this feature!

  • The Range: "all time" is not working.
  • Reducing Range in table view does not work properly
    I saw the initial save report feature ([WIP] Save custom reports #1924) and it's sleek
  • not a big fan of the grey hover color for bar charts and I would remove it in the reports page

idea for the future that I had: net worth view which displays a breakdown of account balance. Ideally with an area chart

@MatissJanis
Copy link
Member

MatissJanis commented Nov 18, 2023

Overall: super impressive work! This is a MASSIVE improvement to Actual. I will personally be using it loads as well! Thanks for all the hard work!

My feedback (sorry for nitpicking):

  • loading indicators - I think we're missing these; for large budgets (such as mine) it takes ~40 seconds for the split_by:payee to load the data - and there is no loading indicator while this is happening.
  • if I change from split_by:payee to split_by:group while payee is still loading - I will get a weird "flash" of the payee data after it finishes loading - I think the previous calculations don't get cancelled
  • the category visibility selector gets hidden on small screens with no ability to scroll in it - I think we're missing a minHeight
  • would be nice to add on-hover tooltips to the icons (i.e. show summary); the native title attribute shows up with a bit of a delay

@Kidglove57
Copy link

When reporting on categories it would be great to have a select and deselect all button. Particularly the latter, In order to quickly narrow down the categories required for a particular report.

@carkom
Copy link
Contributor Author

carkom commented Nov 18, 2023

When reporting on categories it would be great to have a select and deselect all button. Particularly the latter, In order to quickly narrow down the categories required for a particular report.

Can you specify what part of the page you are referring to?

@Kidglove57
Copy link

“Can you specify what part of the page you are referring to?”
Sorry for being unclear! I am referring to the sidebar in the Custom Reports screen where all Groups and Categories are ticked. I would like to be able to “deselect all” (rather than individually deselecting Grouos or Categories. This would make it quicker for me to then individually select just a few categories to compare.

@Shazib
Copy link
Contributor

Shazib commented Nov 18, 2023

Flipping between the 'Type' when in 'Time' mode crashes the app” I have been unable to reproduce this crash on my live budget. Although I do get the crash when selecting a Split other than category EDIT I should have added that this happened in the stacked bar graph. But seems to be fixed in 1930.

Sorry there is an additional step in the sequence

switch from Total to Time, then change the Split

Here is a clip from demo.actualbudget.org

Recording.2023-11-18.181701.mp4

@youngcw youngcw pinned this issue Nov 19, 2023
@carkom
Copy link
Contributor Author

carkom commented Nov 20, 2023

* [x]  loading indicators - I think we're missing these; for large budgets (such as mine) it takes ~40 seconds for the `split_by:payee` to load the data - and there is no loading indicator while this is happening.

Can you check this on #1930? I put in a fix but can't test it since my budget isn't that big...

@Kidglove57
Copy link

* [x]  loading indicators - I think we're missing these; for large budgets (such as mine) it takes ~40 seconds for the `split_by:payee` to load the data - and there is no loading indicator while this is happening.

Can you check this on #1930? I put in a fix but can't test it since my budget isn't that big...

My budget goes back to Dec 2019 so I tested this in Netlifly. I used "all time", in "table view" and in "time mode". Loading time changing from category to payee was 13 seconds in Safari, although no indication that loading was happening.

@Kidglove57
Copy link

PS: Thank you so much for adding in Year to Date and Last Year!

@MatissJanis
Copy link
Member

* [x]  loading indicators - I think we're missing these; for large budgets (such as mine) it takes ~40 seconds for the `split_by:payee` to load the data - and there is no loading indicator while this is happening.

Can you check this on #1930? I put in a fix but can't test it since my budget isn't that big...

Sadly it's still quite slow and doing these "glitches". Tricky to explain what I'm seeing visually.. if you added privacy mode for the Y axis - I could share a screen recording.

@carkom
Copy link
Contributor Author

carkom commented Nov 20, 2023

Sadly it's still quite slow and doing these "glitches". Tricky to explain what I'm seeing visually.. if you added privacy mode for the Y axis - I could share a screen recording.

Due to the way recharts handles YAxis tick labels I'm not sure I can use the "privacyFilter" implementation. I've used it everywhere else (tooltips, legends, etc) but the best I can do for Axis is replace the numbers with a static string variable. I chose '...' for now. Open to changing the string if there's a better or more consistant UI with how we do it elsewhere in the app. Cheers!

@MatissJanis MatissJanis added experimental feature Related to an experimental feature feedback Single feedback thread for bug reports on a new feature and removed bug Something isn't working labels Nov 20, 2023
@MatissJanis
Copy link
Member

Here you go:

Screen.Recording.2023-11-21.at.08.12.28.mov

@Akellade
Copy link

The control side bar isn't very reactive. There seems to be a max height.
This is clear on the categories selection, where there is plenty of space below, but it introduces a scroll bar element :
image

Setting the overflow-y behaviour of the ul element from scroll to auto had the desired result for me.

@carkom
Copy link
Contributor Author

carkom commented Nov 21, 2023

Here you go:
Screen.Recording.2023-11-21.at.08.12.28.mov

I've added a loading indicator. Still not sure what to do to help speed that up though. Payees loading can be quite slow for larger SQL files. Also, not sure how to cancel current data load when something new is clicked - currently it just waits for first one to complete then loads the next one.

Maybe make individual query files and call them via switch statement based on "mode" "groupBy" and "graphType" selections?

@Kidglove57
Copy link

I have also asked for feedback on this in the Project Reports discussion.

My thoughts are then when the Expense view is selected in Reports this should show the net in each expense category, after any refunds. In turn, the Income view should only show Income categories.

At present receipts into an expense category are shown as Income.

Just wondering if this behaviour is intended?
Thanks!

@youngcw
Copy link
Contributor

youngcw commented Nov 27, 2023

At present receipts into an expense category are shown as Income.

@carkom Im looking at one of my categories that is specifically for reimbursements and it isn't acting like you described on discord. I can select expenses only and get what is expected, but net and income views don't show the money coming into the category. My guess is that this is due to the income all being in the form of off-budget to on-budget transfers. Those don't seem to count towards the table data.

@carkom
Copy link
Contributor Author

carkom commented Nov 27, 2023

@carkom Im looking at one of my categories that is specifically for reimbursements and it isn't acting like you described on discord.

Heya! I'm not sure which discord post you're referencing. I posted some suggestions on how it could work but wasn't saying that is how it currently does.

For further understanding of what/how data is displayed. By default the report hides off-budget, hidden categories/groups, empty ($0) categories, and uncategorized transactions. You can choose to show any/all of this data by ticking the corresponding checkbox in the sidebar.

I can select expenses only and get what is expected, but net and income views don't show the money coming into the category. My guess is that this is due to the income all being in the form of off-budget to on-budget transfers. Those don't seem to count towards the table data.

FYI, the app labels transfers as uncategorized transactions that have a "payee.transfer_acct" not equal to null. It shows these in the transactions list of the accounts pages but does not add them to any budget totals since they have no category.

If you'd like to see income for an account select the table graph and Time/Account/Net for the sidebar choices. You can easily see all the income for that account in the "assets" column and all the expenses in the "debts" column.

@Kidglove57
Copy link

Kidglove57 commented Nov 27, 2023

Just chipping in here but maybe I read the question wrongly? The off budget to on budget transfers seem to be key to this comment. They do not of course have a category on the off budget side of the transfer. However, on receipt into the on budget account that side would be categorised.

is @youngcw in fact saying that these categorised inflows are not appearing as income in the Custom Reports OR as a net off against the expense?

@youngcw
Copy link
Contributor

youngcw commented Nov 27, 2023

@Kidglove57 that was what I was trying to get at. The transfers don't get counted as income even though they are categorized in that reimbursement category. That category has a balance of zero on the budget. If I set the custom table report to "net" I only see the expenses and nothing shows up under "income".

@carkom
Copy link
Contributor Author

carkom commented Apr 26, 2024

Not sure if this has been mentioned yet. The scrollbar at the bottom of the table report doesn't have any contrast between the slider and the background (assuming there actually is a slider in that element). It's most easily seen by using a 12 month table by time.

What browser? I'm on Firefox and it looks fine.

@Redbox3070
Copy link

Hi all, I'm looking to take custom reports out from under the experimental features flag. If anyone has any bugs they'd like report I'd welcome any help in fully testing the feature. Cheers!

Something minor I noticed is that a different icon (funnel) for "Filter" is used compared to other sections of actual.

@Teprifer
Copy link

@carkom Awesome! You've done a lot of work on this and I've been using it a bunch lately for some future planning.

Have you updated your original post of this thread with your implemented and may implement in the future?
Could be useful to avoid repeat feedback/requests you've already made a note of.

Are there any specific areas you think need testing out more than others?

On weekly view(just a quick glance now): Currently the date in the header cuts off the day number when showing more than a couple of weeks, possibly wrap around the date in the header into a second line, or abbreviate the year to e.g. '24 ? (or people could use monthly view, hah)

What are your thoughts on tweaking how the Live range "Last X months" works to always exclude the current month(and so go back 1 additional month), when interval = monthly? I'd consider how it's working now as a bug, but there may be other schools of thought on that. :)

The reason I'm asking as I was trying to determine my monthly expenses for the last 12 whole calendar months and I found it a bit clunky having to use specific dates as the current method includes the current month. This means the data used is anywhere from 11.01 months to 11.999 months, but is averaged and totaled as though it was 12 whole months making the numbers inaccurate.

@carkom
Copy link
Contributor Author

carkom commented Apr 26, 2024

Sorry, just to clarify. This is not a request for feature additions or visual changes. It's a bug bashing session, specifically looking for any areas that crash the app or parts of the feature that aren't working correctly.

@carkom
Copy link
Contributor Author

carkom commented Apr 26, 2024

Are there any specific areas you think need testing out more than others?

I am not aware of any bugs or issues currently. Cheers!

On weekly view(just a quick glance now): Currently the date in the header cuts off the day number when showing more than a couple of weeks, possibly wrap around the date in the header into a second line, or abbreviate the year to e.g. '24 ? (or people could use monthly view, hah)

You'll need to specify more info (split, mode, graphtype, etc.)

@carkom
Copy link
Contributor Author

carkom commented Apr 26, 2024

What are your thoughts on tweaking how the Live range "Last X months" works to always exclude the current month(and so go back 1 additional month), when interval = monthly? I'd consider how it's working now as a bug, but there may be other schools of thought on that. :)

The reason I'm asking as I was trying to determine my monthly expenses for the last 12 whole calendar months and I found it a bit clunky having to use specific dates as the current method includes the current month. This means the data used is anywhere from 11.01 months to 11.999 months, but is averaged and totaled as though it was 12 whole months making the numbers inaccurate.

I understand your point and how you're trying to use the feature. I could see it being used both ways. Maybe something we could discuss after it's live?

@Teprifer
Copy link

On weekly view(just a quick glance now): Currently the date in the header cuts off the day number when showing more than a couple of weeks, possibly wrap around the date in the header into a second line, or abbreviate the year to e.g. '24 ? (or people could use monthly view, hah)

You'll need to specify more info (split, mode, graphtype, etc.)

Derp, apologies:

Graph: Data Table
Mode: Time
Split: Category
Interval: Weekly
Date filter live range: Last 3 months

image

@Teprifer
Copy link

What are your thoughts on tweaking how the Live range "Last X months" works to always exclude the current month(and so go back 1 additional month), when interval = monthly? I'd consider how it's working now as a bug, but there may be other schools of thought on that. :)
The reason I'm asking as I was trying to determine my monthly expenses for the last 12 whole calendar months and I found it a bit clunky having to use specific dates as the current method includes the current month. This means the data used is anywhere from 11.01 months to 11.999 months, but is averaged and totaled as though it was 12 whole months making the numbers inaccurate.

I understand your point and how you're trying to use the feature. I could see it being used both ways. Maybe something we could discuss after it's live?

Hrm, changing how calculations and options work within an experimental feature is fair game, but once live it'll see much more use and there's a greater expectation of consistency. Not insurmountable, just cautious. :)

That said it depends on the approach, for example if an additional option to 'Exclude partial* interval' was added**, then the point is moot. Any approach which is saved with the report would work as otherwise a 'last 12 months' report would have to done as a static range and updated each month.

* Place holder wording to communicate thought
* * in the monthly 'last 12 months' case, purely as an example, it would go back an additional +1 month so would still be 12 months. For interval of weekly and 'last 3 months' it'd exclude the current and future weeks and still go back ~3 months.

Ultimately you're the one best placed to consider this point and the work involved for possible approaches so happy to defer to your judgement once you've had time to think it over.

@shall0pass
Copy link
Contributor

Not sure if this has been mentioned yet. The scrollbar at the bottom of the table report doesn't have any contrast between the slider and the background (assuming there actually is a slider in that element). It's most easily seen by using a 12 month table by time.

What browser? I'm on Firefox and it looks fine.

I don't see it on Chrome, Edge, or Brave. I do see it on Firefox.

@cocox
Copy link

cocox commented Apr 26, 2024

Any of these custom reports can be exported as CSV?

@glowtape
Copy link

glowtape commented Apr 26, 2024

The categories list disappears when switching to the area chart (but whatever was checked still applies). Same applies with the donut chart set to Payees.

Is the category list supposed to disappear and theoretically disable? Because it is a quick and easy filter. Say for the donut graph, which payees got how much in the selected set of categories.

@youngcw
Copy link
Contributor

youngcw commented Apr 28, 2024

The data table card is sometimes weird, and maybe always weird on the mobile view. I see this on one of my saved reports on desktop view but not all of them.

Current master
image

the current update PR. Slightly better, but still weird
image

@shall0pass
Copy link
Contributor

Found a bug.

  1. Create a new report
  2. Add a filter
  3. Save report
  4. Change interval

The filter is added again with every change in the interval.

cr_bug

@glowtape
Copy link

glowtape commented Apr 29, 2024

I'm currently implementing an "Exclude current period", where it's supposed to ignore the current week or month, depending on interval, and I noticed this when using the Weekly interval:

image

The first week and the last week in the table report are all zero for some reason, despite there being transactions. Same applies when I use my test budget on a Netlify deployment of #2677 to avoid my own changes. So it doesn't seem my own date fudgery is breaking it.

--edit:
There seems some spilling. If I chose date range "Last Week", which is Apr 22-28, this happens:

image

@carkom
Copy link
Contributor Author

carkom commented Apr 29, 2024

I'm currently implementing an "Exclude current period", where it's supposed to ignore the current week or month, depending on interval, and I noticed this when using the Weekly interval:

Hey mate, I've already got this code ready in a saved branch. Cheers!

@Teprifer
Copy link

Wanted to test 2684 and be able to view column headers in full so tried zooming out and got a reproducible crash - commenting here as I've reproduced it using an edge image pulled just a few minutes ago.

I could only produce this in Chrome, not Firefox. - Default options unless otherwise stated.

Create test budget
Enable custom reporting
Create custom report

  • Data table
  • Mode: Time
  • Range: last 3 months
  • Interval: Daily

Start slowly zooming out - happens at 67%

Error: Minified React error #185; visit https://reactjs.org/docs/error-decoder.html?invariant=185 for the full message or use the non-minified dev environment for full errors and additional helpful warnings. at Eo (https://deploy-preview-2684.demo.actualbudget.org/static/js/index.L2SrLj1H.js:58:33813) at s7 (https://deploy-preview-2684.demo.actualbudget.org/static/js/index.L2SrLj1H.js:56:24854) at https://deploy-preview-2684.demo.actualbudget.org/static/js/ReportRouter.TZjQn1AY.chunk.js:65:64353 at pm (https://deploy-preview-2684.demo.actualbudget.org/static/js/index.L2SrLj1H.js:58:24259) at XT (https://deploy-preview-2684.demo.actualbudget.org/static/js/index.L2SrLj1H.js:58:31595) at Z$ (https://deploy-preview-2684.demo.actualbudget.org/static/js/index.L2SrLj1H.js:58:31451) at x7 (https://deploy-preview-2684.demo.actualbudget.org/static/js/index.L2SrLj1H.js:58:31001) at T7 (https://deploy-preview-2684.demo.actualbudget.org/static/js/index.L2SrLj1H.js:58:40881) at us (https://deploy-preview-2684.demo.actualbudget.org/static/js/index.L2SrLj1H.js:58:40241) at eC (https://deploy-preview-2684.demo.actualbudget.org/static/js/index.L2SrLj1H.js:58:36851)

image

I was also able to reproduce by starting zoomed out on another graph, then changing to data table and zooming out again, crash at 67%
Crashed even just using a blank file too.

@carkom
Copy link
Contributor Author

carkom commented Apr 30, 2024

Wanted to test 2684 and be able to view column headers in full so tried zooming out and got a reproducible crash - commenting here as I've reproduced it using an edge image pulled just a few minutes ago.

I could only produce this in Chrome, not Firefox. - Default options unless otherwise stated.

I'm not able to duplicate this following your steps. Can anyone else confirm if these steps cause a crash? Need a 3rd party to verify or it might be a local issue.

@psybers
Copy link
Contributor

psybers commented Apr 30, 2024

Wanted to test 2684 and be able to view column headers in full so tried zooming out and got a reproducible crash - commenting here as I've reproduced it using an edge image pulled just a few minutes ago.
I could only produce this in Chrome, not Firefox. - Default options unless otherwise stated.

I'm not able to duplicate this following your steps. Can anyone else confirm if these steps cause a crash? Need a 3rd party to verify or it might be a local issue.

I can not reproduce this using #2684. Chrome Version 124.0.6367.62 (Official Build) (x86_64) on OSX 14.4.1 (23E224).

@shall0pass
Copy link
Contributor

Wanted to test 2684 and be able to view column headers in full so tried zooming out and got a reproducible crash - commenting here as I've reproduced it using an edge image pulled just a few minutes ago.
I could only produce this in Chrome, not Firefox. - Default options unless otherwise stated.

I'm not able to duplicate this following your steps. Can anyone else confirm if these steps cause a crash? Need a 3rd party to verify or it might be a local issue.

I can reproduce this on Microsoft Edge.

@carkom
Copy link
Contributor Author

carkom commented Apr 30, 2024

Wanted to test 2684 and be able to view column headers in full so tried zooming out and got a reproducible crash - commenting here as I've reproduced it using an edge image pulled just a few minutes ago.
I could only produce this in Chrome, not Firefox. - Default options unless otherwise stated.

I'm not able to duplicate this following your steps. Can anyone else confirm if these steps cause a crash? Need a 3rd party to verify or it might be a local issue.

I can reproduce this on Microsoft Edge.

I've tried it on MS Edge, Firefox, Chrome, Brave and cannot reproduce. Seems to be an issue tied to the local machine rather than the app?

@shall0pass
Copy link
Contributor

I just tried it on Chrome (desktop) and recreated the bug again. I'm not totally convinced this is an issue with the custom charts though. It may be a bug in the charting library itself. I'm not quite sure how to tell the difference though. However, I cannot reproduce this on my laptop.
cr_bug2

@Teprifer
Copy link

Teprifer commented May 1, 2024

Wanted to test 2684 and be able to view column headers in full so tried zooming out and got a reproducible crash - commenting here as I've reproduced it using an edge image pulled just a few minutes ago.
I could only produce this in Chrome, not Firefox. - Default options unless otherwise stated.

I'm not able to duplicate this following your steps. Can anyone else confirm if these steps cause a crash? Need a 3rd party to verify or it might be a local issue.

I can not reproduce this using #2684. Chrome Version 124.0.6367.62 (Official Build) (x86_64) on OSX 14.4.1 (23E224).

Windows 11,

I was using 124.0.6367.6 3

Updated to: Version 124.0.6367.119 (Official Build) (64-bit) - regular window, but clearing all browsing data, and still getting the crash.
Testing in Edge(just updated to latest), in a private window, Version 124.0.2478.67 (Official build) (64-bit), and got the crash.

Googling "suddenly getting Error: Minified React error #185" it sounds like other apps have started seeing this happening recently, which suggests it's library or browser related rather than custom reports.

E.g.
https://www.reddit.com/r/ClaudeAI/comments/1c2ql5m/application_error_clientside_exception/?rdt=49574
https://wordpress.org/support/topic/minified-react-error-185-with-1-0-4/ (this one has a person tagged 'plugin support' advising the issue was fixed in their plugin.)
https://community.concur.com/t5/Concur-Expense/Keep-Getting-quot-Error-Minified-React-185-quot/m-p/74910

If it's not something that can be fixed within Actual then I don't think it's a show stopper to prevent custom reports moving out of the feature flag.

@Teprifer
Copy link

Teprifer commented May 4, 2024

Just pulled the latest edge and the live x month ranges is starting and ending at the wrong month.

Identified in Firefox and cross checked in a reset browser data chrome window.

All settings except range are the same for the below, also same for other graph types.
12 month range, starts June 2023 and goes to June 2024 (2 images)
image
image

Last 6 months:
image

last 3 months:
image

@bnordio
Copy link

bnordio commented May 5, 2024

One thing that would make the pie/donut chart much more useful in some situations would be the option to deduct deposits from the category spending amount. This would account for large expenses that are reimbursed in parts. To make sure the category amount doesn't go positive, the amount can be clamped at 0, so that only amounts <$0 are represented.

One example of this that greatly skews the chart is being the roommate who pays the rent from their account.

@carkom
Copy link
Contributor Author

carkom commented May 5, 2024

One thing that would make the pie/donut chart much more useful in some situations would be the option to deduct deposits from the category spending amount. This would account for large expenses that are reimbursed in parts. To make sure the category amount doesn't go positive, the amount can be clamped at 0, so that only amounts <$0 are represented.

One example of this that greatly skews the chart is being the roommate who pays the rent from their account.

Use filters?

@TheBlueCircle
Copy link

One thing that would make the pie/donut chart much more useful in some situations would be the option to deduct deposits from the category spending amount. This would account for large expenses that are reimbursed in parts. To make sure the category amount doesn't go positive, the amount can be clamped at 0, so that only amounts <$0 are represented.

One example of this that greatly skews the chart is being the roommate who pays the rent from their account.

Wouldn't that be better fixed by implementing Net as a type for the pie/bar charts?

@bnordio
Copy link

bnordio commented May 11, 2024

One thing that would make the pie/donut chart much more useful in some situations would be the option to deduct deposits from the category spending amount. This would account for large expenses that are reimbursed in parts. To make sure the category amount doesn't go positive, the amount can be clamped at 0, so that only amounts <$0 are represented.
One example of this that greatly skews the chart is being the roommate who pays the rent from their account.

Wouldn't that be better fixed by implementing Net as a type for the pie/bar charts?

That's what I suggested previously but another user pointed out that the "net" value runs the risk of being positive or negative. But long story short, yes, just clamp the value at zero.

@matt-fidd
Copy link
Contributor

matt-fidd commented May 14, 2024

I'm having an issue updating existing custom reports. When I make a change and hit "update report" I get the below error:

image

image

@carkom
Copy link
Contributor Author

carkom commented May 14, 2024

I'm having an issue updating existing custom reports. When I make a change and hit "update report" I get the below error:

image

image

Thanks for the feedback. It's been fixed in an upcoming PR. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental feature Related to an experimental feature feedback Single feedback thread for bug reports on a new feature
Projects
None yet
Development

No branches or pull requests