New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support add connection header thought header apis #3221
base: master
Are you sure you want to change the base?
feat: support add connection header thought header apis #3221
Conversation
@fafhrd91 When can this be merged pls? |
i dont have any affiliation with actix project anymore |
any updates ? |
thanks for running the pipeline, waiting for someone to review it |
someone to review it ? @robjtede |
still waiting for some review. @robjtede how can we move forward with this PR? Seems to have many issues correlated. |
f34dd1a
to
e65c649
Compare
@asonix thanks for your review, can you review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind these changes. There's still the intermediate allocation of the AHashMap but it's probably small (number of headers in a request doesn't exceed 10 in most scenarios probably)
I think Rob still needs to look at this even if I approve it so 🤷
e65c649
to
1295ed5
Compare
resolves #3220