Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection count scoring is skewing the overall score #716

Open
Cyb3r-Monk opened this issue Dec 31, 2021 · 0 comments
Open

Connection count scoring is skewing the overall score #716

Cyb3r-Monk opened this issue Dec 31, 2021 · 0 comments

Comments

@Cyb3r-Monk
Copy link

If my calculations are correct; when the sleep value of a beacon is higher than 10 seconds, the connection count score is greatly impacted which skews the overal score calculation. Below are examples:

Sleep: 10s
Duration: 43200s (12h)
Conn. count: 4320
Conn. score: 1.0

Sleep: 15s
Duration: 43200s (12h)
Conn. count: 2880
Conn. score: 0.66 (big decrease)

Sleep: 30s
Duration: 43200s (12h)
Conn. count: 1440
Conn. score: 0.33 ( huge decrease)

I think the connection count score calculation needs some improvement. Increasing the divisor could help.

tsConnDiv := (float64(a.tsMax) - float64(a.tsMin)) / 10.0 -> maybe 60.0? 
tsConnCountScore := float64(res.ConnectionCount) / tsConnDiv
if tsConnCountScore > 1.0 {
tsConnCountScore = 1.0
}
@Cyb3r-Monk Cyb3r-Monk changed the title Connection count scoring is skewing the overal score Connection count scoring is skewing the overall score Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant