Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin friendly DSL support #8

Open
viniciusccarvalho opened this issue Feb 7, 2019 · 1 comment
Open

Kotlin friendly DSL support #8

viniciusccarvalho opened this issue Feb 7, 2019 · 1 comment

Comments

@viniciusccarvalho
Copy link

It's so nice to see kotlin being used as a standard for java libraries. This is really awesome!

So while I think I understand the reason to rely on ResponseBuilder so that java users can have better interop. One of my favorites things on kotlin is the DSL support for typesafe builders.

I honestly became addicted to it :)

One of my favorites implementations is https://github.com/fkorotkov/k8s-kotlin-dsl

Makes kube-client-dsl so much nicer to use in kotlin projects

So I was wondering if you would be open to accept such PR, I've started working on some extension functions to enable something like:

response {
    card {
      title = "foo"
      subtitle = "bar"
      image {
        url ="http://foo.bar.com/"
        width = 320
        height = 320
      }
    }
  }

So Kotlin developers could benefit from the language nice DSL syntax. It's a good chunk of work, and I'd love to contribute, just want to make sure it's something you would be considering to accept before diving in and submitting a PR of this size.

Cheers

@kishores
Copy link
Contributor

kishores commented Feb 7, 2019

Thanks. Good idea. We will be happy to review and accept the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants