Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarthome integration should expose DisconnectResponse #45

Open
proppy opened this issue Jan 15, 2020 · 3 comments
Open

Smarthome integration should expose DisconnectResponse #45

proppy opened this issue Jan 15, 2020 · 3 comments

Comments

@proppy
Copy link
Contributor

proppy commented Jan 15, 2020

Currently it seems that smarthome integration always returns an empty response for DisconnectRequest.

https://github.com/actions-on-google/actions-on-google-java/blob/master/src/main/kotlin/com/google/actions/api/smarthome/SmartHomeApp.kt#L166

This could be problematic as developer might need to return an errorCode when the DisconnectRequest is failing.

@Fleker
Copy link
Member

Fleker commented Jan 15, 2020

According to the documentation there is no errorCode field for a DisconnectResponse type.

@proppy
Copy link
Contributor Author

proppy commented Jan 16, 2020

Yes but https://developers.google.com/assistant/smarthome/develop/process-intents seems to indicate that most response could return errorCode

@Fleker
Copy link
Member

Fleker commented Jan 16, 2020

This should be clarified more precisely. Even if the DisconnectResponse provided an error code, I don't believe the platform will interpret it. Regardless it seems like it'll disconnect the service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants