Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider dropping JSONObject from the smarthome API surface #43

Open
proppy opened this issue Dec 20, 2019 · 1 comment
Open

consider dropping JSONObject from the smarthome API surface #43

proppy opened this issue Dec 20, 2019 · 1 comment

Comments

@proppy
Copy link
Contributor

proppy commented Dec 20, 2019

Currently the libraries exposes JSONObject as part of the public smarthome API object:
https://github.com/actions-on-google/actions-on-google-java/blob/7f3b1e2fd51e3b044380ea3c72722058ad99240f/src/main/kotlin/com/google/actions/api/smarthome/SmartHomeResponse.kt

This force reverse dependencies to both depens on org.json (as a direct dependency) and gson (transitively).

It would be nice if the library instead only surfaced standard Map<String, Object> types in the public API.

/cc @taycaldwell @Fleker
@Fleker
Copy link
Member

Fleker commented Dec 20, 2019

Yeah we should keep this in mind for the future, although it would end up being a breaking change.

Fleker pushed a commit to google-home/smart-home-java that referenced this issue Apr 7, 2020
@proppy
samples/smarthome/java: remove org.json dep
742257c 
- use gson instead of org.json
- temporarly use actions-on-google deprecated method until
  actions-on-google/actions-on-google-java#43
  is fixed.

Bug: 146618154
Change-Id: I6be48ab602befe3764f6d407c8966b8765369971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@proppy @Fleker