Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distracting quicklisp warnings #861

Open
MattKaufmann opened this issue Jul 15, 2018 · 13 comments
Open

Distracting quicklisp warnings #861

MattKaufmann opened this issue Jul 15, 2018 · 13 comments

Comments

@MattKaufmann
Copy link
Contributor

I think this has cdoame up before, but I can't
remember what was said and I think this deserves
to be a GitHub Issue. Recently an ACL2 user asked
me about this, and in general, such warnings are a
distraction.

Certification of some of the quicklisp books, at
least using CCL (I don't think I've seen this
using SBCL), produces warnings like the following
(this one is taken from
books/centaur/4v-sexpr/sexpr-purebool-p.cert.out).
Note: This is a very long line!

; Warning: System definition file #P"/v/filer4b/v11q002/acl2space/acl2/acl2/books/quicklisp/bundle/software/cl-fad-0.7.4/cl-fad.asd" contains definition for system "cl-fad-test". Please only define "cl-fad" and secondary systems with a name starting with "cl-fad/" (e.g. "cl-fad/test") in that file.

Can someone eliminate these warnings, please?

@ragerdl
Copy link
Member

ragerdl commented Jul 25, 2018

Might be worth updating our quicklisp files and seeing if we still get these warnings.

@MattKaufmann
Copy link
Contributor Author

MattKaufmann commented Jul 26, 2018 via email

@ragerdl
Copy link
Member

ragerdl commented Jul 26, 2018

FWIW, I put some directions on the wiki here:

https://github.com/acl2/acl2/wiki/How-to-update-quicklisp

Which I think is just a rehash of the heading "Adding Quicklisp Libraries" at:

http://www.cs.utexas.edu/users/moore/acl2/manuals/current/manual/index.html?topic=ACL2____QUICKLISP

Regarding difficulty, I don't think there was much to it. It took a while because one has to build the books. And, I seem to recall doing a thing or two that was off-script in order to deal with errors that cropped up. IIRC, the fixes were relatively intuitive from that update.sh script (somewhere in the quicklisp directory).

@MattKaufmann
Copy link
Contributor Author

MattKaufmann commented Jul 26, 2018 via email

@ragerdl
Copy link
Member

ragerdl commented Jul 26, 2018

Hi Matt,

Yeah, I definitely agree that the right place for these things is in the :doc topics. Thanks~

BTW, "start from a clean slate" is a slightly ambiguous version of "make a fresh git clone." And indeed, due to commands in that update-libs.sh script (maybe "git add *" calls... I forget), imo it's best to start with a fresh git clone and not just "make sure that the repo is up to date."

Thanks,
David

@MattKaufmann
Copy link
Contributor Author

MattKaufmann commented Jul 26, 2018 via email

@MattKaufmann
Copy link
Contributor Author

I thought I'd try Sol's instructions. So I cloned acl2 and then, in
books/quicklisp, this happened.

% ./update-libs.sh
Defaulting LISP to ccl
Defaulting STARTJOB to bash
Rebuilding Quicklisp Bundle
./update-libs.sh: 1: cd: can't cd to ../../build
%

Probably I'm not the one to be doing this, since I know nothing about
quicklisp. But I don't think :doc quicklisp is just a rehash of Sol's
instructions, and also, Sol's instructions mention update.sh but now
it's presumably update-libs.sh.

I hope someone will sort this out; that's very unlikely to be me.

@ragerdl
Copy link
Member

ragerdl commented Aug 5, 2018

Somehow my change to update-libs.sh didn't make it in last time. Basically, one "../" needs to be removed from that cd call. Working on this.

@MattKaufmann
Copy link
Contributor Author

Thanks, David! I apologize for not noticing Issue #813; I guess this is really the same issue.

@ragerdl
Copy link
Member

ragerdl commented Aug 6, 2018

Ran out of memory too much to get this done this weekend. Hope to look into it again soon but reviewing papers is probably higher priority.

@ragerdl
Copy link
Member

ragerdl commented Nov 6, 2018

No idea whether the warnings are now fixed, but I did finally update quicklisp.

@acoglio
Copy link
Member

acoglio commented Jun 19, 2022

Is this Issue still relevant/applicable?

@MattKaufmann
Copy link
Contributor Author

It's still relevant. I don't know if it happens in other than CCL, but I'm still seeing it with CCL on Linux and Mac. Here's an example of Mac.

~/acl2/acl2-git-scratch$ time fgrep --include='*.cert.out' -ri 'System definition file' .
./books/centaur/misc/tshell-tests.cert.out:; Warning: System definition file #P"/Users/kaufmann/acl2/acl2-git-scratch/books/quicklisp/bundle/software/cl-fad-20200610-git/cl-fad.asd" contains definition for system "cl-fad-test". Please only define "cl-fad" and secondary systems with a name starting with "cl-fad/" (e.g. "cl-fad/test") in that file.
[... and lots more]

Here's evidence for "and lots more" (not an exact count, because that regression isn't quite finished):

~/acl2/acl2-git-scratch/books$ fgrep --include='*.cert.out' -ri 'System definition file' . | wc -l
     229
~/acl2/acl2-git-scratch/books$ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants