This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
Start to modernize recompose (...) #826
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid using the deprecated React.createFactory function (and update .size-snapshot.json) resolves acdlite#806
and update Jest config with setupFilesAfterEnv
and update eslint-disable & eslint-enable comments with TODO comments in src/packages/recompose/utils/mapValues.js due to an issue with recent eslint versions
and disable react/default-props-match-prop-types in one place in src/packages/recompose/__tests__/toClass-test.js
- eslint-plugin-import -> ^2.22.1 - eslint-plugin-jsx-a11y -> ^6.4.1
and disable jsx-a11y/label-has-associated-control in one test in src/packages/recompose/__tests__/withHandlers-test.js
override componentDidMount instead of componentWillMount lifecycle method in order to avoid one of the warnings coming from React 16.14.0 and (hopefully) continue to work with older React versions and add a TODO comment
brodybits
commented
Feb 4, 2021
| @@ -29,7 +29,7 @@ export const componentFromStreamWithConfig = config => propsToVdom => | |||
| // Stream of vdom | |||
| vdom$ = config.toESObservable(propsToVdom(this.props$)) | |||
|
|
|||
| componentWillMount() { | |||
| componentDidMount() { | |||
There was a problem hiding this comment.
I am not sure if this change, which is probably the safest way to support multiple React versions and forks, could lead to potential loss of optimization or any other potential issues.
Comment on lines
+42
to
45
| // TODO: componentWillReceiveProps method is not supported by React 17; | ||
| // UNSAFE_componentWillReceiveProps may not work with older React versions. | ||
| // Another solution is wanted. | ||
| componentWillReceiveProps(nextProps) { |
Comment on lines
+3
to
+5
| // NOTE: This is intended to be an internal utility for now, may be | ||
| // unit-tested, documented, and exported by the API in the future. | ||
| export default function __createFactory(c) { |
There was a problem hiding this comment.
I think it would be nice to export and document this in the API.
Comment on lines
+3
to
7
| // TODO: no-unused-vars seems to trigger a issue in recent eslint versions | ||
| /* eslint-disable no-restricted-syntax, no-unused-vars */ | ||
| for (const key in obj) { | ||
| if (obj.hasOwnProperty(key)) { | ||
| result[key] = func(obj[key], key) |
There was a problem hiding this comment.
I would like to find a nicer, cleaner solution for this without potentially breaking ES5 consumers.
This was referenced Mar 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated:
createFactory#806Some TODO items:
distartifacts before updating the build-related dependencies.