Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove dependency request-promise from packages/oauth #981

Merged
merged 1 commit into from
May 18, 2020
Merged

chore(deps): remove dependency request-promise from packages/oauth #981

merged 1 commit into from
May 18, 2020

Conversation

agustif
Copy link
Contributor

@agustif agustif commented May 17, 2020

I will open another PR for removing it specificallly from oauth-instagram package. should be easy to repalce like with twitter package using this.oauth instead!

This would partially fix #937

@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #981 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #981   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files          80       80           
  Lines        1788     1788           
  Branches      384      384           
=======================================
  Hits         1702     1702           
  Misses         84       84           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3791bb...10be3ed. Read the comment docs.

@pradel pradel merged commit 1b4b0d3 into accounts-js:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request-promise is deprecated
2 participants