@accounts/password username validation

[MohanNarayana]

The username validation is done against this regex pattern /^[a-zA-Z][a-zA-Z0-9]*$/
Is there a reason why username must start with a letter? I feel it should accept any alphanumeric starting with a letter or number(all numbers too). Is changing this validation a consideration?

Thanks,
Mohan

[pradel]

Changing the regex is not really an option as it would be a breaking change for existing users. However you can use your own regex easily with this option https://www.accountsjs.com/docs/api/password/interfaces/accountspasswordoptions#optional-validateusername

[pradel]

Okay that's strange, can you try to use the validateNewUser option instead? You can do the validation for the username like in this example https://www.accountsjs.com/docs/strategies/password#extend-the-user-and-validate-custom-fields

[MohanNarayana]

I tried validateNewUser. It does not override the default validation. Maybe it only validates the extended fields?
With validateUsername I could see the validation override. Should validateUsername return an error or boolean? Or should it return nothing?

[pradel]

This is the code responsible for the check https://github.com/accounts-js/accounts/blob/master/packages/password/src/accounts-password.ts#L601, returning false should work properly.

[pradel]

can you share the configuration you are using for the project?

[MohanNarayana]

It is an open source eCommerce Node project. It has a distributed API architecture and the api plugin for authentication, where I am adding the code is here