Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to CMake build script for adding definitions #826

Open
geirhei opened this issue Dec 4, 2022 · 0 comments
Open

Add options to CMake build script for adding definitions #826

geirhei opened this issue Dec 4, 2022 · 0 comments

Comments

@geirhei
Copy link

geirhei commented Dec 4, 2022

Several options are added in the CMakeLists.txt from CCI used when creating the conan package: https://github.com/conan-io/conan-center-index/pull/14332/files#diff-ea375b62cb31e3394d050d0bb1267949c9abe74b84e714056725e1a28ce4ce3fR35

They should instead be included in the build script for this project so that they are available to others as well. For instance:

option(disable_logs "Disables all logs" OFF)
if (disable_logs)
    add_definitions(-DELPP_DISABLE_LOGS)
endif()

Should also fix #812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant