Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI runs successfully even when invalid arguments are passed #61

Open
SharpSeeEr opened this issue Mar 24, 2023 · 2 comments
Open

CLI runs successfully even when invalid arguments are passed #61

SharpSeeEr opened this issue Mar 24, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@SharpSeeEr
Copy link

Describe the bug
When invalid arguments are passed on the command line the program still runs successfully, ignoring any arguments it doesn't know about. I discovered this by accident when running it for the first time (ever): npx commit-and-tag-version --dr-run (note the misspelled word "dry").

Current behavior
Running npx commit-and-tag-version --dryrun results in the changelog being generated, version bumped, committed, and tagged.

Expected behavior
The program should exit with an error, potentially displaying the help

Environment

  • commit-and-tag-version version(s): 11.2.0
  • Node/npm version: Node 16.19.0, npm 9.3.0
  • OS: PopOS 22.04
@SharpSeeEr SharpSeeEr added the bug Something isn't working label Mar 24, 2023
@TimothyJones
Copy link
Member

Thanks for the report! That's a pretty unpleasant bug, we should definitely fix this.

I'll link this to #31 , which is an overhaul of the options.

@helmturner
Copy link

helmturner commented Apr 6, 2023

#69 Will address this, once complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants