Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted commits are included in the generated CHANGELOG.md #132

Open
tadayosi opened this issue Mar 15, 2024 · 0 comments
Open

Reverted commits are included in the generated CHANGELOG.md #132

tadayosi opened this issue Mar 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@tadayosi
Copy link

Firstly of all, thank you very much for this great tool! I really like it.

Describe the bug
When I do release with commit-and-tag-version, it smartly recognise reverted commits and decide version to increment based on the rest of semver commits.

For example, if the commit history has 3 fix: commits and one feat:, but also has one Revert "feat:..." commit, it smartly recognise the reverted one and decide the version, say, 1.0.0 -> 1.0.1, not -> 1.1.0. This is awesome!

However, when I look at the generated CHANGELOG.md, it unfortunately includes the reverted feat: item in the Features section.

Current behavior
The reverted commits are still included in the generated CHANGELOG.md

Expected behavior
The reverted commits should be ignored in the generated CHANGELOG.md just like when the tool decides a new version to increment: 1.0.0 -> 1.0.1

Environment

  • commit-and-tag-version version(s): 12.2.0
  • Node/npm version: Node v20.9.0/npm 10.2.5/yarn 4.1.1
  • OS: Linux Fedora release 39

Possible Solution

Additional context

@tadayosi tadayosi added the bug Something isn't working label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant