MG-2142 - Consume Things connect/disconnect event in bootstrap #2192
+673
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffMboya
force-pushed
the
MG-2142
branch
3 times, most recently
from
90b9f69
to
3198bd8
Compare
arvindh123
reviewed
Apr 25, 2024
arvindh123
reviewed
Apr 25, 2024
They are not the same. The event published by things service is a notification that a thing has been connected or disconnected from a channel. The event published by |
arvindh123
reviewed
Apr 26, 2024
arvindh123
reviewed
Apr 26, 2024
arvindh123
requested changes
Apr 26, 2024
arvindh123
reviewed
Apr 26, 2024
arvindh123
requested changes
Apr 26, 2024
There was a problem hiding this comment.
While trying to assign parent group for channel , like below request
curl --location 'http://localhost/channels/795b0be8-f8d9-4101-a40f-859ed573c71c/groups/assign' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer <Token>' \
--data '{
"group_ids" : [ "5c6de392-6dc4-46fc-8e2c-e6f4ce4fffab" ]
}'In events received below logs, which use group.assign operation , the same operation is used for thing connect, so could not different between thing connection event and group assign channel events
[#8] Received on "events.magistrala.things" with reply "_INBOX.7g7jymtBXH0wOSok79kUGo.0LlN1Z1P"
*�{"group_id":"795b0be8-f8d9-4101-a40f-859ed573c71c","member_ids":["5c6de392-6dc4-46fc-8e2c-e6f4ce4fffab"],"occurred_at":1714131210669902557,"operation":"group.assign"}
Additionally,
In the event message group_id filed contains channel id
actually here we should have group id
In member_ids field , it contains
group_id , actually here we should have channel id
This issue might be a blocker for this PR
JeffMboya
force-pushed
the
MG-2142
branch
2 times, most recently
from
0b87686
to
9380eef
Compare
JeffMboya
force-pushed
the
MG-2142
branch
3 times, most recently
from
15ddd1f
to
068d129
Compare
JeffMboya
changed the title
JeffMboya
force-pushed
the
MG-2142
branch
6 times, most recently
from
b78c9aa
to
f6aa2fe
Compare
rodneyosodo
requested changes
May 17, 2024
| repo := postgres.NewConfigRepository(db, testLog) | ||
| err := deleteChannels(context.Background(), repo) | ||
| require.Nil(t, err, "Channels cleanup expected to succeed.") | ||
|
|
There was a problem hiding this comment.
Test this occurrences using table testing:
- Connect for an already connected thing
- Connect for a disconnected thing
- Connect for an invalid thing
- Connect for a random thing
- Connect for an empty thing
JeffMboya
force-pushed
the
MG-2142
branch
2 times, most recently
from
386c14c
to
73f7017
Compare
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
rodneyosodo
requested changes
May 23, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
rodneyosodo
requested changes
May 27, 2024
arvindh123
requested changes
May 27, 2024
arvindh123
requested changes
May 27, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
arvindh123
requested changes
May 28, 2024
arvindh123
requested changes
May 28, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
arvindh123
previously approved these changes
May 28, 2024
rodneyosodo
requested changes
May 28, 2024
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
Signed-off-by: JeffMboya <jangina.mboya@gmail.com>
arvindh123
approved these changes
May 30, 2024
arvindh123
requested review from
rodneyosodo,
WashingtonKK and
felixgateru
and removed request for
WashingtonKK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the connectEvent struct to the consumer package.
What does this do?
This PR adds a new struct, connectEvent, to the consumer package. This struct contains the thingID and channelID, and is triggered whenever a Thing connects to the system.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests for my changes.
Did you document any new/modified feature?
No