Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort / reverse modify arrays in-place #405

Open
odino opened this issue Sep 21, 2020 · 1 comment
Open

sort / reverse modify arrays in-place #405

odino opened this issue Sep 21, 2020 · 1 comment
Milestone

Comments

@odino
Copy link
Collaborator

odino commented Sep 21, 2020

possibly strings as well -- and there might be some other functions that modify things in place themselves...shuffle / flatten etc all work on a copy.

It'd be good to just unify this behavior...

@odino odino added this to the 2.4.x milestone Sep 21, 2020
@odino odino changed the title sort / reverse modify arrays in -place sort / reverse modify arrays in-place Sep 21, 2020
@odino odino modified the milestones: 2.4.x, cauldron Sep 28, 2020
@mcampbell
Copy link

While unifying is great, I'd unify on the "returns a copy of the modified array/string" direction. If you ever want to get into threading or anything, immutability goes a long way in eliminating all sorts of race conditions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants