Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trekking profile and cycle-routes #622

Open
EssBee59 opened this issue Aug 28, 2023 · 9 comments
Open

Trekking profile and cycle-routes #622

EssBee59 opened this issue Aug 28, 2023 · 9 comments
Labels

Comments

@EssBee59
Copy link
Collaborator

It seems, the standard trekking profile do not calculate the right costs when a cycle route is defined on a way

2 examples:

http://brouter.de/brouter-web/#map=14/49.9399/8.9582/osm-mapnik-german_style&lonlats=8.954887,49.953097;8.924436,49.887188

http://brouter.de/brouter-web/#map=13/49.9767/8.5679/osm-mapnik-german_style&lonlats=8.578911,49.990673;8.451819,49.947091

bug_trekking.txt

(see cost of 1.000 / km for secondary and tertiary...)

@quaelnix
Copy link
Collaborator

I would call this a feature and not a bug:

#
# handle long-distance cycle-routes.
#
else if ( is_ldcr ) then 1 # always treated as perfect (=1)

and if you dislike this behavior you can simply toggle the ignore_cycleroutes switch?

@EssBee59
Copy link
Collaborator Author

EssBee59 commented Aug 30, 2023

I do not understand the behavior, especially by a trekking profile.
So I hope the developper(s) of the profile check that, a mistake by the handling cycle_route possibly exists ?

(every trekking router that I know will not route on the secondary hw between Babenhausen and Langstadt, this is too dangerous)
This profile is the default profile of the Brouter, each new user will start with it and the default parameters:
Should he first learn how to change the parameters and especially 1 of the 30 parameters of this profile?

See:
......
assign is_ldcr =
if ignore_cycleroutes then false
else any_cycleroute
....
and
....
else if ( is_ldcr ) then 1 # always treated as perfect (=1)
...
So, a cycle_route (possibly defined for race-bikers who used that way once at a week.end without traffic) impacts the costfactor dramatically (primary get the same cost as the best cycleway t.m "1".

@quaelnix
Copy link
Collaborator

The comment in the code says:

always treated as perfect (=1)

and the code does do that.

this is too dangerous

Flip the avoid_unsafe switch?

a mistake by the handling cycle_route possibly exists ?

I don't think that there is a good solution for the dilemma that you cannot make a profile that works perfectly world wide, see the examples in the first post of this thread: #479

@quaelnix
Copy link
Collaborator

possibly defined for race-bikers who used that way once at a week

Bis auf wenige Ausnahmen verläuft sie getrennt vom Autoverkehr.

With a few exceptions, it runs separately from car traffic.

It seems obvious that the route relation in OSM is simply wrong.

@quaelnix
Copy link
Collaborator

quaelnix commented Aug 30, 2023

The official map clearly shows that the route is not supposed to be on the L 3065 between Babenhausen and Langstadt!

@EssBee59
Copy link
Collaborator Author

EssBee59 commented Aug 31, 2023

Of course, errors in OSM are possible.
But I think this is not a unique case.
See quick search with overpass (not giving a perfect result, but helpful)

rel({{bbox}})["route"="bicycle"]->.rels;
(way(r.rels)["highway"="primary"]["cycleway"!"lane"]["cycleway:both"!"lane"];>;);
out;

or
rel({{bbox}})["route"="bicycle"]->.rels;
(way(r.rels)["highway"="secondary"]["cycleway"!"lane"]["cycleway:both"!"lane"];>;);
out;

@quaelnix
Copy link
Collaborator

Here is a reasonably correct overpass query: https://overpass-turbo.eu/s/1zDU

@poutnikl
Copy link
Contributor

Nobody should say parameters of the default trekking profile are complex until meeting mine. :-)

@EssBee59
Copy link
Collaborator Author

EssBee59 commented Nov 7, 2023

See discussion in #641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants