Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal]: Add ffmpeg creationflag in Writegear API #377

Closed
4 tasks done
abhiTronix opened this issue Sep 2, 2023 · 1 comment · Fixed by #375 or #378
Closed
4 tasks done

[Proposal]: Add ffmpeg creationflag in Writegear API #377

abhiTronix opened this issue Sep 2, 2023 · 1 comment · Fixed by #375 or #378
Labels
ENHANCEMENT ⚡ New Feature/Addition/Improvement PROPOSAL 📩 A proposal/proposition SOLVED 🏁 This issue/PR is resolved now. Goal Achieved!
Projects
VidGear v0.3.2
Milestone
v0.3.2

Comments

@abhiTronix
Copy link
Owner

abhiTronix commented Sep 2, 2023 •
edited

Issue guidelines

Issue Checklist

  • I have searched open or closed issues and found nothing related to my idea.
  • I have read the Documentation and it doesn't mention anything about my idea.
  • To my best knowledge, my idea wouldn't break something for other users.

Describe your Idea

See #375 for reference
I propose a new feature to enable detached subprocess creation on Windows within the writegear module. This enhancement enhances the process management capabilities of the module.

Use Cases

See #375 for reference
This can be useful while creating an exe file for a python script that uses writegear. On windows even after creating the exe file in windowed mode or no-console mode, the ffmpeg.exe command line window would pop up while its being used by write gear.
@abhiTronix abhiTronix added ENHANCEMENT ⚡ New Feature/Addition/Improvement WORK IN PROGRESS 🚧 currently been worked on. PROPOSAL 📩 A proposal/proposition labels Sep 2, 2023
@abhiTronix abhiTronix added this to the v0.3.2 milestone Sep 2, 2023
@abhiTronix abhiTronix added this to To do in VidGear v0.3.2 via automation Sep 2, 2023
@abhiTronix abhiTronix linked a pull request Sep 2, 2023 that will close this issue
Writegear ffmpeg creationflag #375
Merged
4 tasks
abhiTronix added a commit that referenced this issue Sep 3, 2023
@abhiTronix
⚡️WriteGear: Added new ffmpeg creationflag (fixes #377) [#375]
2e6c928 
- ✨ Added a new feature to enable detached subprocess creation on Windows within the WriteGear API. 
  - 🧑‍💻 This enhancement enhances the process management capabilities of the module.
  - ♿️ Use Case: This can be useful while creating an exe file for a python script that uses WriteGear API. On windows even after creating the exe file in windowed mode or no-console mode, the ffmpeg.exe command line window would pop up while its being used by WriteGear API.
- 🚩 Added new `ffmpeg_subprocess_creation_window` Boolean flag to enable this feature.
- ⚡️This feature can be enabled both in logging and silent mode.
@abhiTronix abhiTronix moved this from To do to In progress in VidGear v0.3.2 Sep 3, 2023
abhiTronix added a commit that referenced this issue Sep 3, 2023
@abhiTronix
🧱 WriteGear: Replaced class parameter with optional flag. (Fixes #377)
5d9c5a3 
- ✨ Added new `-disable_ffmpeg_window` optional Boolean flag to enable patch that prevents FFmpeg creation window from opening when building .exe files on Windows OS.
  - ⚡️Note: Now `-disable_ffmpeg_window` optional Boolean flag is only available on Windows OS with logging disabled(`logging=False`) in compression mode.
- 🚩 Removed `ffmpeg_subprocess_creation_window` class parameter.
- 🥅 Disabled this patch for logging mode.
- 🔥 Removed redundant code.
- 🔊 Updated logging.
@abhiTronix abhiTronix linked a pull request Sep 4, 2023 that will close this issue
Major enhancements and bugfixes #378
Merged
6 tasks
@abhiTronix abhiTronix mentioned this issue Sep 4, 2023
Merged
6 tasks
@abhiTronix
Copy link
Owner Author

Successfully resolved and merged in commit 3c0dd5d

VidGear v0.3.2 automation moved this from In progress to Done Sep 6, 2023
@abhiTronix abhiTronix added SOLVED 🏁 This issue/PR is resolved now. Goal Achieved! and removed WORK IN PROGRESS 🚧 currently been worked on. labels Sep 6, 2023
@abhiTronix abhiTronix pinned this issue Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ENHANCEMENT ⚡ New Feature/Addition/Improvement PROPOSAL 📩 A proposal/proposition SOLVED 🏁 This issue/PR is resolved now. Goal Achieved!
Projects
No open projects
VidGear v0.3.2
Done
Milestone
v0.3.2
1 participant
@abhiTronix