Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should resholve complain about overridden essential builtins? #27

Open
abathur opened this issue May 16, 2021 · 0 comments
Open

Should resholve complain about overridden essential builtins? #27

abathur opened this issue May 16, 2021 · 0 comments
Labels
feedback wanted Looking for user input.

Comments

@abathur
Copy link
Owner

abathur commented May 16, 2021

resholve special-cases a number of builtins (alias, builtin, command, coproc, eval, and .|source) to resolve executables that appear in their arguments.

In theory, resholve might do the "wrong" thing if these builtins are obscured by a function or alias that changes their behavior.

I considered making these an error--but I'll start with a warning because I suspect that syntax/semantic-incompatible replacements are rare in the real world (and compatible replacements would have to triage).

If you ran into this warning, I'm curious how/why the builtin was overridden in the script you tried to resolve.

@abathur abathur added the feedback wanted Looking for user input. label May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted Looking for user input.
Projects
None yet
Development

No branches or pull requests

1 participant