-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fisheye/Panorama not flipped #1257
Comments
The panorama is generated after the image is flipped, so the flipped image is used. I will look into adding the cardinal directions to the panorama. |
I guess it just looks odd. I have the panorama set so that the center is looking south. IN that case, I would expect the sun/moon to rise from the left -> right (east -> west). However, the image is flipped ... It goes from right -> left. The cardinal directions for this image would be N-W-S-E-N .. and would expect it to be N-E-S-W-N ... |
I never really paid attention to how it was generated. This is just how the fish2pano python module works. |
I took a look at that project. In it he has 2 sample images. From them you can tell that the result is actually a mirror image (the text on the image is mirrored). Wonder if you can just do a mirror of the result to get it back to normal. Add a switch to the config to enable/disable it. |
I'm guessing it is just reading the image counter-clockwise. I'll look into adding an option to flip the image horizontally. |
Nevermind, after reviewing the images, its reading them clockwise. |
Merged #1264 with the ability to add cardinal directions to panoramas. There are options to flip the panorama as well. I had to setup some special test images to figure out details about the panorama. The first important point was the the starting point of the panorama, which is 90 degrees clockwise and the progression is clockwise from that point. The image needs to be rotated -90 degrees to get the bottom of the image to be the center of the panorama. |
I've updated to the latest code. It looks good so far. Thanks for the update! |
I have both "Flip Image Vertically" and "Flip Image Horizontally" enabled for my camera. However, it does not look like the panorama generation takes these settings into account.
Also, as a "feature" it might be nice to add the cardinal markers (N/S/E/W) at the bottom of the image.
Thanks.
The text was updated successfully, but these errors were encountered: