Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Byte ranges generated by XhrFileReader.js are invalid #177

Open
robinfriedli opened this issue Jun 21, 2023 · 0 comments
Open

Bug: Byte ranges generated by XhrFileReader.js are invalid #177

robinfriedli opened this issue Jun 21, 2023 · 0 comments

Comments

@robinfriedli
Copy link

The XhrFileReader defines the end of the byte range as such:

range[1] = Math.min(self._size, range[1]);

This is incorrect, because byte ranges are inclusive and should therefor always be lower than the size. It should:

range[1] = Math.min(self._size - 1, range[1]);

From mdn:

<range-end>
An integer in the given unit indicating the end position (zero-indexed & inclusive) of the requested range.

This may cause servers to reject the request with a 416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant