Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate lint check from unit-tests stage in circleci #475

Open
syncush opened this issue Oct 8, 2020 · 8 comments
Open

Separate lint check from unit-tests stage in circleci #475

syncush opened this issue Oct 8, 2020 · 8 comments
Labels
good first issue Good for newcomers

Comments

@syncush
Copy link
Collaborator

syncush commented Oct 8, 2020

As of today unit-tests stage do two things:

  1. linting
  2. run unit tests

We should separate the two things into two different stages

@Niaz-Ul-Haque
Copy link

Please assign, I am interested! Thank you!

@enudler
Copy link
Collaborator

enudler commented Oct 8, 2020

@Niaz-Ul-Haque it's yours :)

@Niaz-Ul-Haque
Copy link

Niaz-Ul-Haque commented Oct 11, 2020

Hello, sorry for the late reply. I tried installing the repo on my local machine, but it seems to be giving me errors when installing. I followed the steps it's written in the documentation, but still.

I tried lots of things, but nothing as of now.

My errors might be very begineer-ish, its cause it's my first time on an opensource project, so please have mercy lol

@Niaz-Ul-Haque
Copy link

I know i maybe have problems with my machine, but i did fix them, still not working.

> predator@1.5.4 setup-local-env C:\Users\Niaz\Desktop\git\predator
> npm install --no-save shelljs && node setup-env.js
npm WARN @apidevtools/swagger-parser@10.0.2 requires a peer of openapi-types@>=7 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
+ shelljs@0.8.4
updated 1 package and audited 1488 packages in 35.955s
54 packages are looking for funding
  run `npm fund` for details
found 0 vulnerabilities
Starting Predator local setup, good luck!
npm WARN @apidevtools/swagger-parser@10.0.2 requires a peer of openapi-types@>=7 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@2.1.2 (node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@2.1.2: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
audited 1488 packages in 15.085s
54 packages are looking for funding
  run `npm fund` for details
found 0 vulnerabilities
npm WARN tarball tarball data for monaco-editor@0.19.3 (sha512-2n1vJBVQF2Hhi7+r1mMeYsmlf18hjVb6E0v5SoMZyb4aeOmYPKun+CE3gYpiNA1KEvtSdaDHFBqH9d7Wd9vREg==) seems to be corrupted. Trying one more time.
npm ERR! code EPERM
npm ERR! syscall unlink
npm ERR! path C:\Users\Niaz\Desktop\git\predator\ui\node_modules\.staging\monaco-editor-d5ad47e4\dev\vs\editor\editor.main.js
npm ERR! errno -4048
npm ERR! Error: EPERM: operation not permitted, unlink 'C:\Users\Niaz\Desktop\git\predator\ui\node_modules\.staging\monaco-editor-d5ad47e4\dev\vs\editor\editor.main.js'
npm ERR!  [OperationalError: EPERM: operation not permitted, unlink 'C:\Users\Niaz\Desktop\git\predator\ui\node_modules\.staging\monaco-editor-d5ad47e4\dev\vs\editor\editor.main.js'] {
npm ERR!   cause: [Error: EPERM: operation not permitted, unlink 'C:\Users\Niaz\Desktop\git\predator\ui\node_modules\.staging\monaco-editor-d5ad47e4\dev\vs\editor\editor.main.js'] {
npm ERR!     errno: -4048,
npm ERR!     code: 'EPERM',
npm ERR!     syscall: 'unlink',
npm ERR!     path: 'C:\\Users\\Niaz\\Desktop\\git\\predator\\ui\\node_modules\\.staging\\monaco-editor-d5ad47e4\\dev\\vs\\editor\\editor.main.js' 
npm ERR!   },
npm ERR!   errno: -4048,
npm ERR!   code: 'EPERM',
npm ERR!   syscall: 'unlink',
npm ERR!   path: 'C:\\Users\\Niaz\\Desktop\\git\\predator\\ui\\node_modules\\.staging\\monaco-editor-d5ad47e4\\dev\\vs\\editor\\editor.main.js',  
npm ERR!   parent: 'ui'
npm ERR! }
npm ERR!
npm ERR! The operation was rejected by your operating system.
npm ERR! It's possible that the file was already in use (by a text editor or antivirus),
npm ERR! or that you lack permissions to access it.
npm ERR!
npm ERR! If you believe this might be a permissions issue, please double-check the
npm ERR! permissions of the file and its containing directories, or try running
npm ERR! the command again as root/Administrator.
npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\Niaz\AppData\Roaming\npm-cache\_logs\2020-10-08T21_31_42_945Z-debug.log
Error: npm ci failed for the frontend
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! predator@1.5.4 setup-local-env: `npm install --no-save shelljs && node setup-env.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the predator@1.5.4 setup-local-env script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\Niaz\AppData\Roaming\npm-cache\_logs\2020-10-08T21_31_43_367Z-debug.log

@enudler
Copy link
Collaborator

enudler commented Oct 11, 2020

hi @Niaz-Ul-Haque
try to upgrade monaco-editor, in ui/package.json to a newer version maybe it will help
although it works fine for me and this is the first I see this issue.

@enudler
Copy link
Collaborator

enudler commented Oct 16, 2020

hi @Niaz-Ul-Haque how is it going?
are you still on this issue?

@abdel6602
Copy link

Hello,
is this issue resolved or can i try it?

@enudler
Copy link
Collaborator

enudler commented Jul 13, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants