Skip to content
This repository has been archived by the owner on Feb 11, 2020. It is now read-only.

Hardcoded low-resolution cover image URL #32

Open
bstegmaier opened this issue Apr 16, 2017 · 2 comments
Open

Hardcoded low-resolution cover image URL #32

bstegmaier opened this issue Apr 16, 2017 · 2 comments

Comments

@bstegmaier
Copy link

Summary
The low resolution cover image is not configurable and hard-coded as /images/cover.low.jpg.

Steps to reproduce

  • Remove any static/images/cover* files
  • Add an image static/images/any_name_other_than_cover.jpg
  • Configure it to be the cover image:
   cover = "/images/any_name_other_than_cover.jpg"
  • Serve and browse the site

Result
Chrome console complains about a non-existing /images/cover/low.jpg file.

Suggested fix
How about making the low res cover configurable via e.g. .Site.Params.coverLow?
This is the relevant line:

<div class="header-cover blured-image" style="background-color: darkgreen; background-image: url(/images/cover.low.jpg)" data-src="{{ .Site.Params.cover }}"></div>

@Zenithar
Copy link
Owner

PR are welcome ^^

@curtiscde
Copy link
Contributor

Sounds like a great idea. Basically making the low res version of the cover image an optional feature.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants