Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Drop controller plugin and view helper #558

Open
adamlundrigan opened this issue Jan 25, 2015 · 3 comments
Open

[RFC] Drop controller plugin and view helper #558

adamlundrigan opened this issue Jan 25, 2015 · 3 comments

Comments

@adamlundrigan
Copy link
Contributor

I propose we drop the controller plugin and view helpers bundled with ZfcUser.

Rationale:

  • ZF2 already provides a bundled identity view helper and controller plugin that render zfcUserIdentity redundant.
  • zfcUserDisplayName has a hard-coded fallback cascade (display_name -> username -> email) that isn't broadly applicable in my opinion. It's best left to the application to decide how to handle empty fields.
  • zfcUserLoginWidget should be offered as an addon module for those who need it
adamlundrigan added a commit to adamlundrigan/ZfcUser that referenced this issue Jan 25, 2015
@adamlundrigan
Copy link
Contributor Author

#554 will need an update if this is merged

@Danielss89
Copy link
Member

Agree, let's drop those.

@stijnhau
Copy link

stijnhau commented Apr 6, 2015

Indead the widget should be a separate module.

the zfcUserDisplayName is indead kinda lame because is 100% harcoded.
I see a use case for it but then the field to show should be configurable.
i think this is even better then removing it.
In that case we can use that simple helper to show the most important field of the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants