unique idents should not be indexed with {:index-all? true}

[jtmarmon]

A unique identity attribute is always indexed by value, in order to support uniqueness checks. Specifying :db/index true is redundant and not recommended.

http://docs.datomic.com/identity.html#unique-identities

[CmdrDats]

@jtmarmon Thanks - but datomic-schema doesn't automatically add the indexed property unless you've asked specifically to add it or you've said you want every attribute indexed, so I don't really see how this is relevant?

[jtmarmon]

I'm merely suggesting that there should be an extra option or something...the point of index-all? is to follow datomic guidelines that you should index everything. Well part of those guidelines is to not index :unique-identity since it's already indexed

[CmdrDats]

Ah, I see - it's particularly around index-all, sorry - I misunderstood the intent of the task. I'll happily accept a PR to improve this.