Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enricher_internal.R code may have mistake #52

Open
tangmaomao16 opened this issue Aug 20, 2021 · 1 comment
Open

enricher_internal.R code may have mistake #52

tangmaomao16 opened this issue Aug 20, 2021 · 1 comment

Comments

@tangmaomao16
Copy link

At the 100th line code in https://github.com/YuLab-SMU/DOSE/blob/master/R/enricher_internal.R, it is numWdrawn=k-1, it should represent the number of the real terms we get, but why minus one? I think 'minus one' is wrong. The right code should be numWdrawn=k
@huerqiang
Copy link
Contributor

Maybe you should learn more about "Fisher's exact test":
https://www.pathwaycommons.org/guide/primers/statistics/fishers_exact_test/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tangmaomao16 @huerqiang