Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUPIP FTOK -JNLPOOL and -RECVPOOL needs to honor input file name if specified #313

Open
nars1 opened this issue Jul 19, 2018 · 0 comments
Open
Assignees
Projects
Milestone

Comments

@nars1
Copy link
Collaborator

nars1 commented Jul 19, 2018

Final Release Note

Description

The below command currently works even though does not exist in the file system or if it points to a file that is not a valid replication instance file.

mupip ftok -jnlpool <filename>

MUPIP FTOK looks at the replication instance file defined by the ydb_repl_instance environment variable. And not at the input file name specified. It would be nice to honor the input file name and treat that as an instance file instead of deriving it from the environment variable.

Whils the current behavior was okay when there was just one replication instance file, with GTM-8182 changes in GT.M V6.3-003, a process can access multiple instance files and so it would be desirable for MUPIP FTOK to also recognize multiple instance files.

Draft Release Note

MUPIP FTOK -JNLPOOL and MUPIP FTOK -RECVPOOL operate on the specified instance-file-name. Previously they used to ignore the input instance-file-name and always operate on the instance file name derived from the ydb_repl_instance (or gtm_repl_instance) environment variable.

@nars1 nars1 added this to the r124 milestone Jul 19, 2018
@nars1 nars1 self-assigned this Jul 19, 2018
@nars1 nars1 added this to To do in r1.24 via automation Jul 19, 2018
chathaway-codes pushed a commit that referenced this issue Oct 25, 2018
…ication instance file name

repl_inst_get_name() was called unconditionally before and that set the "instfilename" variable
to point to the instance file name pointed to by the "ydb_repl_instance" env var. And ignored
the filename specified by the user in the command line ("fn"). This call to repl_inst_get_name()
is now removed and the repl_inst_read() is done with "fn" instead of "instfilename". That
ensures the user specified file name is used in MUPIP FTOK -JNLPOOL and MUPIP FTOK -RECVPOOL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
r1.24
  
To do
Development

No branches or pull requests

1 participant