Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service monitor triggered from two callbacks #272

Open
dnephin opened this issue Sep 9, 2013 · 0 comments
Open

Service monitor triggered from two callbacks #272

dnephin opened this issue Sep 9, 2013 · 0 comments

Comments

@dnephin
Copy link
Contributor

dnephin commented Sep 9, 2013

tron.core.service.Service has a repair_callback which calls instances.restore() which calls monitor_task.run().

tron.core.serviceinstance.ServiceInstance has a MonitorTask which calls it's queue() every time it completes.

This results in many warnings 'monitor action already exists' and may lead to other errors. I believe that Server.restore() should only recreate instances, and should let the instance take care of running the monitor on its own.

@solarkennedy solarkennedy added this to Backlog in Yelp/paasta Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant