Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug on demo: not handling keyboard and back button correctly #2

Open
AndroidDeveloperLB opened this issue Apr 3, 2017 · 4 comments

Comments

@AndroidDeveloperLB
Copy link

clicking on the search action item should trigger the keyboard because it should allow us to start typing.

The X should be shown only when there is text being written, and we should have an arrow to close the search, which should also close the keyboard.
Instead, what I see is a single X button that clears the query and only then closes, but even when it closes, it doesn't close the keyboard.

Not only that, but when clicking the back button, it closes the activity even if there is still text written. When we are editing the text, and then click on the back button, it should either close the keyboard , or close the editing (or both, as done on the play store).

@igalata
Copy link
Contributor

igalata commented Apr 3, 2017

Hello @AndroidDeveloperLB
Thanks for your feedback, I'll fix the sample app soon :) But just to make it clear, it's not a bug in the library, since all events are handled in sample app and the content view is also provided by it.

@AndroidDeveloperLB
Copy link
Author

ok, so please try to make it like on Google Play or other Google apps. It works weird now, as we users are used to another behavior...

@igalata
Copy link
Contributor

igalata commented Apr 3, 2017

@AndroidDeveloperLB
I'll surely try. But please notice, that we didn't try to make a copy of the search view from the Play Store or any other applications, this animation is our design concept. So it seems odd to alter it to make it look like components from other applications, doesn't it? Of course all other issues you mentioned should be fixed

@AndroidDeveloperLB
Copy link
Author

I don't talk about the animation and design. I talk about the behavior...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants