Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract factory for plugins #81

Open
romancardenas opened this issue Nov 12, 2021 · 1 comment
Open

Abstract factory for plugins #81

romancardenas opened this issue Nov 12, 2021 · 1 comment

Comments

@romancardenas
Copy link
Contributor

Hi,

I was a contributor of HBMQTT, and I remember that dealing with custom plugins was a pain.

For my work, I started using the abstract factory pattern for plugins in Python, and that works pretty well. It allows users to add their custom plugins dynamically by just calling a method. I do believe this pattern is more user-friendly and can fit in AMQTT.

Before implementing it, I wanted to ask about your opinion. If you are not interested in this change, I'll leave plugins alone :)

@one4many
Copy link

Having implemented plugins myself I would welcome this change. I personally don't like the current handling because it requires a custom setup.py file and with every change in the plugins I need to re-install the amqtt module itself. I feels like 'monkey-patching' something all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants