Add exception stack traces to logging #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linter fails. Can you please have a look @plbertrand. Apart from that I think this looks great. Thanks |
plbertrand
force-pushed
the
exception-logging
branch
2 times, most recently
from
1614ac9
to
0e76cd3
Compare
plbertrand
force-pushed
the
exception-logging
branch
from
0e76cd3
to
9d51ecc
Compare
FlorianLudwig
approved these changes
Apr 17, 2022
| except ClientException as ce: | ||
| logger.error("Client exception: %s" % ce) | ||
| except ClientException: | ||
| logger.error("Client exception", exc_info=True) |
There was a problem hiding this comment.
Suggested change
| logger.error("Client exception", exc_info=True) | |
| logger.exception("Client exception") |
As you suggested in #105 the exception shortcut is nice 👍 This could be an opportunity to move to it.
|
@plbertrand thanks for your contribution! Do you want to move to For some log statements, I wonder why we should include a traceback at all. For example when the connection aborts this is a network error - not a programming error. Some log levels also seem wrong to me. But both are out of scope of this MR. This is an improvement already as is! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105