Skip to content
This repository has been archived by the owner on Apr 23, 2019. It is now read-only.

global is not defined error running full-example from fresh repo clone #129

Open
shalomvolchok opened this issue Jun 7, 2017 · 1 comment
Labels

Comments

@shalomvolchok
Copy link

When I run the full-example, in production mode, I get Uncaught ReferenceError: global is not defined in the browser. I saw recent discussion around this and it looks like global.foo was added to footer.js as a test case and that mendel added a default shim for global with c97a12e. But maybe I'm seeing that wrong and need to add it manually somewhere?

@irae
Copy link
Collaborator

irae commented Jun 8, 2017

Thank you very much for filing the issue. We are working hard to get the "onboarding" as clear as possible and I saw the same issue and totally forgot to track it.

We recently added support for global shim and somehow the production mode slipped from our tests. I'll soon take a look into this.

@shalomvolchok just bear in mind that unless your project or one of your dependencies actually use global in the code, you should not be affected by this issue. In case you are, you can add var global=global||window; in any file that require use of global and it should work until we fix this issue.

@irae irae added the bug label Jun 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants