Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

galleryview won't display descriptions #1

Open
tribut opened this issue Mar 23, 2014 · 0 comments
Open

galleryview won't display descriptions #1

tribut opened this issue Mar 23, 2014 · 0 comments

Comments

@tribut
Copy link

tribut commented Mar 23, 2014

With enable_overlays = true, jQuery-GalleryView tries to read the description from data-description="foo" whereas yag seems to write to longdesc="bar". I would have opened a pull-request against galleryview itself, but that repository seems to be pretty much dead, so I wanted to make you aware of it at least. My suggestion for a fix is

--- jquery.galleryview-3.0-dev-orig.js  2014-03-23 18:46:04.301446813 +0100
+++ jquery.galleryview-3.0-dev.js   2014-03-23 18:58:57.058986430 +0100
@@ -33,7 +33,7 @@
        this.width = 0;
        this.attrs = {
            title: img.attr('title') || img.attr('alt'),
-           description: img.data('description')
+           description: img.data('description') || img.attr('longdesc')
        };
        this.href = null;
        this.dom_obj = null;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant