Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type for OrderLineItem quantity #749

Open
lukewarlow opened this issue Jul 12, 2023 · 0 comments · May be fixed by #750
Open

Incorrect type for OrderLineItem quantity #749

lukewarlow opened this issue Jul 12, 2023 · 0 comments · May be fixed by #750

Comments

@lukewarlow
Copy link

OrderLineItem's quantity is declared as an optional decimal. However, according to the WooCommerce API docs quantity is an integer.

Quantity being a decimal also wouldn't really make sense as someone can't order half an item.
lukewarlow added a commit to lukewarlow/WooCommerce.NET that referenced this issue Jul 12, 2023
@lukewarlow
Correct OrderLineItem quantity to a ulong not a decimal
0641454 
Fixes XiaoFaye#749
@lukewarlow lukewarlow linked a pull request Jul 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correct OrderLineItem quantity to a ulong not a decimal lukewarlow/WooCommerce.NET
1 participant
@lukewarlow