Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified algorithm for heat flow calculation #498

Open
Harmon9802 opened this issue Dec 21, 2023 · 3 comments
Open

Modified algorithm for heat flow calculation #498

Harmon9802 opened this issue Dec 21, 2023 · 3 comments

Comments

@Harmon9802
Copy link
Contributor

Describe the bug
The right hand side of diffusion_dt_ algorithm in all of diffusion types (Inner, Robin, etc. ) only calculate the rate of heat flow per unit volume (W/m3), we need to multiply a particle volume term to get heat flow (W), then we can use it for heat flux calculation.

Trace to the source
Steps to trace the source:

  1. Go to 'diffusion_dynamics.hpp'.
  2. Scroll down to 'DiffusionRelaxation<Robin<...>>' for example.
  3. Find two functions inside of the class ”getDiffusionChangeRateRobin“ and "interaction".
  4. Check the algorithm of diffusion_dt_.

Modified algorithm
The modified diffusion_dt_m should be:
diffusion_dt_m = diffusion_dt_ * particle_volume

Additional context
However, this bug does not effect the final temperature field calculation, it is only useful if we want to calculate overall heat flow instead of volumetric heat flow.

@Harmon9802 Harmon9802 changed the title Modified algorithm for heat flux calculation Modified algorithm for heat flow calculation Dec 21, 2023
@DrChiZhang
Copy link
Collaborator

Please check the thermal_diffusion branch, where more general thermal dynamics equations are solved.

@Xiangyu-Hu
Copy link
Owner

@DrChiZhang could you make a pull request if you think the changes are done?

@DrChiZhang
Copy link
Collaborator

@DrChiZhang could you make a pull request if you think the changes are done?

Sure, I will try to merge master to this branch first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants