Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obvious repeat on define diffusion particles and material #427

Open
Xiangyu-Hu opened this issue Sep 4, 2023 · 1 comment
Open

obvious repeat on define diffusion particles and material #427

Xiangyu-Hu opened this issue Sep 4, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Xiangyu-Hu
Copy link
Owner

Xiangyu-Hu commented Sep 4, 2023

The two lines shows that

using DiffusionParticles = DiffusionReactionParticles<SolidParticles, DiffusionMaterial>;

and

diffusion_body.defineParticlesAndMaterial<DiffusionParticles, DiffusionMaterial>();

repeat the use of diffusion material.

@Xiangyu-Hu
Copy link
Owner Author

I will revise this by: 1. using single type for all particles, 2. the variables will be registered in diffusion-reaction material or in diffusion reaction methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants